1521223 - Add an interface to deliberately leak an object

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

It would be good if we had a mochitest unit test for leak checking, to cover the case where an object leaks. Right now there is one, but it uses a fake leak log. We need some interface that can be called from privileged JS that can leak an object that will show up in the leak log. The object it leaks shouldn't be used otherwise.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1521223, part 1 - Add an API to deliberately leak an object.

This is needed to test various leak checking harnesses.

Comment 2

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1521223, part 2 - Update the leakcheck test to work on a real leak log.

Depends on D17310

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

In the second patch, I updated the mochitest test to actually leak, using the API I added in part 1, but the status and level reported are "warning" instead of some kind of failure like the ASan one. Is that expected? It seems weird, but I'm not at all familiar with how this works.

Comment 4

[Andrew McCreight (out of office until 8/21) [:mccr8]]

ahal explained in the review comment that "warning" means "orange". I'm too used to thinking of compiler warnings, which are non-fatal...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7955097a8041
part 1 - Add an API to deliberately leak an object. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/0b9c766c352f
part 2 - Update the leakcheck test to work on a real leak log. r=ahal

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7955097a8041
https://hg.mozilla.org/mozilla-central/rev/0b9c766c352f