Closed Bug 1521296 Opened 6 years ago Closed 6 years ago

Remove XUL grid layout from security/manager/pki/resources/content/setp12password.xul

Categories

(Firefox :: Settings UI, task, P3)

Product:
Firefox
Component:
Settings UI
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox66 --- verified
firefox67 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(3 files)

Screen Shot 2019-01-19 at 13.20.05.png
460.47 KB, image/png
Details
UI with patch applied
536.72 KB, image/png
Details
Bug 1521296 - Remove XUL grid layout from security/manager/pki/resources/content/setp12password.xul.
47 bytes, text/x-phabricator-request
Details | Review

Similar to bug 1521294 and bug 1521285.

certdialogs.setPKCS12FilePassword(window, {})

Attached image UI with patch applied —

Unlike the other bugs which don't do any visual changes, this one actually does some.

One way we can preserve the layout is to use HTML tables.

Assignee: nobody → ntim.bugs
Priority: -- → P3
Assignee: ntim.bugs → nobody
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fb80118393dc
Remove XUL grid layout from security/manager/pki/resources/content/setp12password.xul. r=keeler

https://hg.mozilla.org/mozilla-central/rev/fb80118393dc

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Assignee: nobody → ntim.bugs

This issue is verified fixed using Firefox 66.0b13 (BuildId:20190304101322) and Firefox 67.0a1 (BuildId:20190306095759) on Windows 10 64bit, Windows 7 64bit, macOS 10.12.6 and Ubuntu 18.04 64bit.

Status: RESOLVED → VERIFIED
status-firefox66: fixed → verified
status-firefox67: --- → verified
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: