Closed Bug 1521340 Opened 6 years ago Closed 6 years ago

Simplify CSS variables for icon colors

Categories

(DevTools :: Framework, enhancement)

Product:
DevTools
Component:
Framework
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

References

Details

Attachments

(1 file)

Bug 1521340 - Simplify icon color CSS variables; r=ntim
47 bytes, text/x-phabricator-request
Details | Review

We're using the same icon colors outside of toolbars too, so let's make it official and try to cut down on code that uses slightly different colors for icons.

Related: https://github.com/devtools-html/debugger.html/issues/7743

Assignee: nobody → florens
Status: NEW → ASSIGNED
  • Remane --theme-toolbar-icon-color to just --theme-icon-color
  • Rename --theme-toolbar-checked-color to --theme-icon-checked-color
  • Introduce a --theme-icon-alt-color that is less contrasted (e.g. for Rules icon buttons)
  • Avoid partial opacity variants of Photon Grey as global variables in variables.css
Attachment #9037818 - Attachment description: Bug 1521340 - Simplify icon color CSS variables; r=gl → Bug 1521340 - Simplify icon color CSS variables; r=ntim
Summary: Rename --theme-toolbar-icon-color CSS variable to --theme-icon-color → Simplify CSS variables for icon colors
Pushed by florens@fvsch.com: https://hg.mozilla.org/integration/autoland/rev/d5962d1b5b32 Simplify icon color CSS variables; r=ntim

https://hg.mozilla.org/mozilla-central/rev/d5962d1b5b32

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: