Closed Bug 1521413 Opened 6 years ago Closed 6 years ago

Update pdf.js to version 2.1.215

Categories

(Firefox :: PDF Viewer, task)

Product:
Firefox
Component:
PDF Viewer
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

+++ This bug was initially created as a clone of Bug #1521182 +++

Changes since last update:
#10466 Move/refactor the code in the BaseViewer.update method to reduce duplication in the extending classes
#10467 Convert some usage of indexOf to startsWith/includes where applicable
#10471 Implement a unit test for metadata parsing to ensure that it's not vulnerable to the billion laughs attack
#10470 Try to, completely, avoid loading the ReadableStream polyfill in MOZCENTRAL builds
#10473 Add an Array.from polyfill, using core-js, and remove some compatibility hacks from the src/display/content_disposition.js file
#10474 Update translations and packages

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5b887c68abd Update pdf.js to version 2.1.209. r=bdahl

Backed out changeset a5b887c68abd (bug 1521413) for browser-chrome failures in browser/base/content/test/static/browser_all_files_referenced.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222965618&repo=mozilla-inbound&lineNumber=1638

INFO - TEST-START | browser/base/content/test/static/browser_all_files_referenced.js
[task 2019-01-20T20:11:12.499Z] 20:11:12 INFO - TEST-INFO | started process screentopng
[task 2019-01-20T20:11:12.962Z] 20:11:12 INFO - TEST-INFO | screentopng: exit 0
[task 2019-01-20T20:11:12.962Z] 20:11:12 INFO - Buffered messages logged at 20:11:03
[task 2019-01-20T20:11:12.962Z] 20:11:12 INFO - Entering test bound checkAllTheFiles
[task 2019-01-20T20:11:12.963Z] 20:11:12 INFO - Buffered messages logged at 20:11:12
[task 2019-01-20T20:11:12.963Z] 20:11:12 INFO - indirectly whitelisted file: chrome://marionette/content/test_dialog.dtd used from chrome://marionette/content/test_dialog.xul
[task 2019-01-20T20:11:12.963Z] 20:11:12 INFO - indirectly whitelisted file: chrome://global-platform/locale/intl.properties used from resource://gre/greprefs.js
[task 2019-01-20T20:11:12.968Z] 20:11:12 INFO - indirectly whitelisted file: chrome://marionette/content/test.xul used from chrome://marionette/content/test_anonymous_content.xul
[task 2019-01-20T20:11:12.969Z] 20:11:12 INFO - indirectly whitelisted file: chrome://marionette/content/test_nested_iframe.xul used from chrome://marionette/content/test.xul
[task 2019-01-20T20:11:12.971Z] 20:11:12 INFO - indirectly whitelisted file: chrome://marionette/content/test2.xul used from chrome://marionette/content/test.xul,chrome://marionette/content/test_nested_iframe.xul
[task 2019-01-20T20:11:12.972Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/addonutils.js used from resource://services-sync/engines/addons.js
[task 2019-01-20T20:11:12.976Z] 20:11:12 INFO - indirectly whitelisted file: resource://gre/modules/Promise-backend.js used from resource://gre/modules/Promise.jsm,resource://devtools/shared/worker/loader.js,resource://devtools/shared/Loader.jsm
[task 2019-01-20T20:11:12.977Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/engines/clients.js used from resource://services-sync/service.js
[task 2019-01-20T20:11:12.979Z] 20:11:12 INFO - indirectly whitelisted file: chrome://pippki/content/resetpassword.js used from chrome://pippki/content/resetpassword.xul
[task 2019-01-20T20:11:12.980Z] 20:11:12 INFO - indirectly whitelisted file: chrome://global/content/accessibility/content-script.js used from resource://gre/modules/accessibility/AccessFu.jsm
[task 2019-01-20T20:11:12.983Z] 20:11:12 INFO - indirectly whitelisted file: chrome://global/content/remote-test-ipc.js used from chrome://global/content/test-ipc.xul
[task 2019-01-20T20:11:12.984Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/telemetry.js used from resource://services-sync/bookmark_repair.js,resource://services-sync/service.js
[task 2019-01-20T20:11:12.987Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/stages/enginesync.js used from resource://services-sync/service.js
[task 2019-01-20T20:11:12.988Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/addonsreconciler.js used from resource://services-sync/engines/addons.js
[task 2019-01-20T20:11:12.989Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/collection_validator.js used from resource://services-sync/engines/addons.js,resource://services-sync/engines/forms.js,resource://services-sync/engines/passwords.js
[task 2019-01-20T20:11:12.991Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/policies.js used from resource://services-sync/service.js
[task 2019-01-20T20:11:12.992Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/bookmark_validator.js used from resource://services-sync/engines/bookmarks.js
[task 2019-01-20T20:11:12.995Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/browserid_identity.js used from resource://services-sync/telemetry.js,resource://services-sync/status.js
[task 2019-01-20T20:11:12.996Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-common/tokenserverclient.js used from resource://services-sync/browserid_identity.js
[task 2019-01-20T20:11:12.997Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/status.js used from resource://services-sync/telemetry.js,resource://services-sync/policies.js,resource://services-sync/service.js
[task 2019-01-20T20:11:12.999Z] 20:11:12 INFO - indirectly whitelisted file: resource://services-sync/collection_repair.js used from resource://services-sync/engines/clients.js,resource://services-sync/bookmark_repair.js,resource://services-sync/doctor.js
[task 2019-01-20T20:11:13.000Z] 20:11:13 INFO - indirectly whitelisted file: resource://services-sync/stages/declined.js used from resource://services-sync/service.js
[task 2019-01-20T20:11:13.003Z] 20:11:13 INFO - indirectly whitelisted file: chrome://pippki/content/load_device.js used from chrome://pippki/content/load_device.xul
[task 2019-01-20T20:11:13.004Z] 20:11:13 INFO - indirectly whitelisted file: resource://services-sync/engines.js used from resource://services-sync/engines/clients.js,resource://services-sync/engines/addons.js,resource://services-sync/engines/forms.js,resource://services-sync/engines/history.js,resource://services-sync/engines/tabs.js,resource://services-sync/engines/bookmarks.js,resource://services-sync/engines/extension-storage.js,resource://services-sync/engines/passwords.js,resource://services-sync/engines/prefs.js,resource://services-sync/service.js,resource://formautofill/FormAutofillSync.jsm
[task 2019-01-20T20:11:13.006Z] 20:11:13 INFO - indirectly whitelisted file: resource://services-common/logmanager.js used from resource://services-sync/policies.js
[task 2019-01-20T20:11:13.007Z] 20:11:13 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/EventManager.jsm used from chrome://global/content/accessibility/content-script.js
[task 2019-01-20T20:11:13.014Z] 20:11:13 INFO - indirectly whitelisted file: resource://gre/modules/Http.jsm used from resource://app/modules/translation/GoogleTranslator.jsm,resource://app/modules/translation/YandexTranslator.jsm,resource://app/modules/translation/BingTranslator.jsm
[task 2019-01-20T20:11:13.015Z] 20:11:13 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Utils.jsm used from chrome://global/content/accessibility/content-script.js,resource://gre/modules/accessibility/Traversal.jsm,resource://gre/modules/accessibility/EventManager.jsm,resource://gre/modules/accessibility/AccessFu.jsm,resource://gre/modules/accessibility/ContentControl.jsm
[task 2019-01-20T20:11:13.016Z] 20:11:13 INFO - indirectly whitelisted file: resource://gre/modules/SyncedBookmarksMirror.jsm used from resource://services-sync/engines/bookmarks.js
[task 2019-01-20T20:11:13.017Z] 20:11:13 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Constants.jsm used from chrome://global/content/accessibility/content-script.js,resource://gre/modules/accessibility/Traversal.jsm,resource://gre/modules/accessibility/EventManager.jsm,resource://gre/modules/accessibility/Utils.jsm,resource://gre/modules/accessibility/ContentControl.jsm
[task 2019-01-20T20:11:13.019Z] 20:11:13 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/ContentControl.jsm used from chrome://global/content/accessibility/content-script.js
[task 2019-01-20T20:11:13.020Z] 20:11:13 INFO - indirectly whitelisted file: chrome://passwordmgr/content/recipes.json used from resource://gre/greprefs.js
[task 2019-01-20T20:11:13.021Z] 20:11:13 INFO - indirectly whitelisted file: resource://formautofill/FormAutofillSync.jsm used from resource://services-sync/service.js
[task 2019-01-20T20:11:13.022Z] 20:11:13 INFO - indirectly whitelisted file: chrome://global/locale/AccessFu.properties used from resource://gre/modules/accessibility/Utils.jsm
[task 2019-01-20T20:11:13.023Z] 20:11:13 INFO - indirectly whitelisted file: resource://services-sync/bookmark_repair.js used from resource://services-sync/collection_repair.js
[task 2019-01-20T20:11:13.024Z] 20:11:13 INFO - indirectly whitelisted file: resource://services-sync/doctor.js used from resource://services-sync/bookmark_repair.js,resource://services-sync/stages/enginesync.js
[task 2019-01-20T20:11:13.025Z] 20:11:13 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Traversal.jsm used from resource://gre/modules/accessibility/ContentControl.jsm
[task 2019-01-20T20:11:13.027Z] 20:11:13 INFO - Buffered messages finished
[task 2019-01-20T20:11:13.029Z] 20:11:13 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected 0
[task 2019-01-20T20:11:13.032Z] 20:11:13 INFO - Stack trace:
[task 2019-01-20T20:11:13.033Z] 20:11:13 INFO - chrome://mochikit/content/browser-test.js:test_is:1318
[task 2019-01-20T20:11:13.033Z] 20:11:13 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:746
[task 2019-01-20T20:11:13.034Z] 20:11:13 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1108
[task 2019-01-20T20:11:13.035Z] 20:11:13 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1099
[task 2019-01-20T20:11:13.036Z] 20:11:13 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:997
[task 2019-01-20T20:11:13.037Z] 20:11:13 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-01-20T20:11:13.038Z] 20:11:13 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-01-20T20:11:13.042Z] 20:11:13 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: resource://pdf.js/build/streams_polyfill.js -
[task 2019-01-20T20:11:13.043Z] 20:11:13 INFO - Stack trace:
[task 2019-01-20T20:11:13.043Z] 20:11:13 INFO - chrome://mochikit/content/browser-test.js:test_ok:1307
[task 2019-01-20T20:11:13.044Z] 20:11:13 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:750
[task 2019-01-20T20:11:13.045Z] 20:11:13 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1108
[task 2019-01-20T20:11:13.046Z] 20:11:13 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1099
[task 2019-01-20T20:11:13.047Z] 20:11:13 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:997
[task 2019-01-20T20:11:13.048Z] 20:11:13 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-01-20T20:11:13.049Z] 20:11:13 INFO - ignored unused whitelist entry: resource://app/blocklist.xml
[task 2019-01-20T20:11:13.051Z] 20:11:13 INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json
[task 2019-01-20T20:11:13.056Z] 20:11:13 INFO - ignored unused whitelist entry: resource://gre/res/test.properties
[task 2019-01-20T20:11:13.057Z] 20:11:13 INFO - missing file: resource://gre/modules/commonjs/toolkit/loader.js
[task 2019-01-20T20:11:13.058Z] 20:11:13 INFO - missing file: chrome://pippki/content/security/certificates/deviceManager.ftl referenced from chrome://pippki/content/load_device.xul,chrome://pippki/content/device_manager.xul
[task 2019-01-20T20:11:13.059Z] 20:11:13 INFO - missing file: chrome://pippki/content/security/certificates/certManager.ftl referenced from chrome://pippki/content/editcacert.xul,chrome://pippki/content/certManager.xul,chrome://pippki/content/exceptionDialog.xul,chrome://pippki/content/deletecert.xul,chrome://pippki/content/certViewer.xul
[task 2019-01-20T20:11:13.060Z] 20:11:13 INFO - missing file: chrome://mozapps/content/extensions/branding/brand.ftl referenced from chrome://mozapps/content/extensions/extensions.xul,chrome://mozapps/content/extensions/shortcuts.html
[task 2019-01-20T20:11:13.061Z] 20:11:13 INFO - missing file: chrome://mozapps/content/extensions/toolkit/about/aboutAddons.ftl referenced from chrome://mozapps/content/extensions/extensions.xul,chrome://mozapps/content/extensions/shortcuts.html
[task 2019-01-20T20:11:13.062Z] 20:11:13 INFO - missing file: chrome://mozapps/content/preferences/toolkit/preferences/preferences.ftl referenced from chrome://mozapps/content/preferences/removemp.xul,chrome://mozapps/content/preferences/changemp.xul
[task 2019-01-20T20:11:13.063Z] 20:11:13 INFO - missing file: chrome://help/content/help.js referenced from chrome://pippki/content/protectedAuth.xul
[task 2019-01-20T20:11:13.065Z] 20:11:13 INFO - missing file: chrome://pippki/content/branding/brand.ftl referenced from chrome://pippki/content/exceptionDialog.xul
[task 2019-01-20T20:11:13.067Z] 20:11:13 INFO - missing file: chrome://mozapps/content/update/toolkit/updates/history.ftl referenced from chrome://mozapps/content/update/history.xul
[task 2019-01-20T20:11:13.068Z] 20:11:13 INFO - missing file: chrome://mozapps/content/preferences/branding/brand.ftl referenced from chrome://mozapps/content/preferences/changemp.xul
[task 2019-01-20T20:11:13.071Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/aboutConfig.ftl referenced from chrome://global/content/config.xul
[task 2019-01-20T20:11:13.072Z] 20:11:13 INFO - missing file: resource://gre/modules/GeckoViewTelemetryController.jsm referenced from resource://gre/components/ContentProcessSingleton.js
[task 2019-01-20T20:11:13.073Z] 20:11:13 INFO - missing file: resource://services-sync/)%20==%200)%20%7B referenced from resource://services-sync/addonutils.js
[task 2019-01-20T20:11:13.078Z] 20:11:13 INFO - missing file: resource://gre/modules/worker/myModule.js referenced from resource://gre/modules/workers/require.js
[task 2019-01-20T20:11:13.080Z] 20:11:13 INFO - missing file: resource://gre/modules/workers/SimpleTest.js referenced from resource://gre/modules/workers/require.js
[task 2019-01-20T20:11:13.081Z] 20:11:13 INFO - missing file: resource://gre/modules/workers/Logger.js referenced from resource://gre/modules/workers/require.js
[task 2019-01-20T20:11:13.082Z] 20:11:13 INFO - missing file: resource://search-extensions/ referenced from resource://gre/components/nsSearchService.js
[task 2019-01-20T20:11:13.091Z] 20:11:13 INFO - missing file: resource://gre/modules/MulticastDNSAndroid.jsm referenced from resource://gre/components/nsDNSServiceDiscovery.js
[task 2019-01-20T20:11:13.092Z] 20:11:13 INFO - missing file: resource://gre/modules/WindowsRegistry.jsm referenced from resource://gre/components/nsUpdateService.js,resource://gre/modules/NativeManifests.jsm,resource://gre/modules/UpdateUtils.jsm,resource://gre/modules/TelemetryEnvironment.jsm,resource://app/components/nsBrowserGlue.js,resource://app/modules/MigrationUtils.jsm,resource://app/modules/ShellService.jsm
[task 2019-01-20T20:11:13.097Z] 20:11:13 INFO - missing file: resource://gre/modules/Snackbars.jsm referenced from chrome://global/content/aboutSupport.js
[task 2019-01-20T20:11:13.103Z] 20:11:13 INFO - missing file: chrome://gfxsanity/content/sanityparent.html referenced from resource://gre/components/marionette.js
[task 2019-01-20T20:11:13.104Z] 20:11:13 INFO - missing file: resource://gre/modules/Messaging.jsm referenced from chrome://global/content/aboutTelemetry.js,resource://gre/modules/ReaderMode.jsm,resource://gre/modules/PushRecord.jsm,resource://gre/modules/accessibility/AccessFu.jsm
[task 2019-01-20T20:11:13.105Z] 20:11:13 INFO - missing file: resource://gre/modules/*.svg referenced from resource://gre/modules/PageThumbUtils.jsm
[task 2019-01-20T20:11:13.106Z] 20:11:13 INFO - missing file: resource://gre/modules/OSCrypto_win.js referenced from resource://gre/modules/OSCrypto.jsm
[task 2019-01-20T20:11:13.108Z] 20:11:13 INFO - missing file: resource://gre/modules/osfile/osfile_win_allthreads.jsm referenced from resource://gre/modules/osfile/osfile_async_front.jsm,resource://gre/modules/osfile/osfile_native.jsm
[task 2019-01-20T20:11:13.109Z] 20:11:13 INFO - missing file: chrome://browser/content/extension-mac.css referenced from resource://gre/modules/ExtensionParent.jsm
[task 2019-01-20T20:11:13.113Z] 20:11:13 INFO - missing file: resource://gre/modules/subprocess/subprocess_win.jsm referenced from resource://gre/modules/Subprocess.jsm
[task 2019-01-20T20:11:13.114Z] 20:11:13 INFO - missing file: resource://gre/modules/osfile/osfile_win_back.jsm referenced from resource://gre/modules/osfile.jsm
[task 2019-01-20T20:11:13.115Z] 20:11:13 INFO - missing file: resource://gre/modules/osfile/osfile_win_front.jsm referenced from resource://gre/modules/osfile.jsm
[task 2019-01-20T20:11:13.116Z] 20:11:13 INFO - missing file: resource://gre/modules/RuntimePermissions.jsm referenced from resource://gre/modules/DownloadIntegration.jsm
[task 2019-01-20T20:11:13.118Z] 20:11:13 INFO - missing file: resource://android/ referenced from resource://gre/modules/UserAgentUpdates.jsm
[task 2019-01-20T20:11:13.119Z] 20:11:13 INFO - missing file: resource://gre/modules/PushServiceAndroidGCM.jsm referenced from resource://gre/modules/PushService.jsm
[task 2019-01-20T20:11:13.126Z] 20:11:13 INFO - missing file: chrome://global/content/manifestMessages.js referenced from resource://gre/modules/ManifestObtainer.jsm
[task 2019-01-20T20:11:13.127Z] 20:11:13 INFO - missing file: chrome://extensions/content/schemas/manifest/version referenced from chrome://extensions/content/schemas/management.json
[task 2019-01-20T20:11:13.128Z] 20:11:13 INFO - missing file: chrome://extensions/content/schemas/manifest/version#version_name referenced from chrome://extensions/content/schemas/management.json
[task 2019-01-20T20:11:13.129Z] 20:11:13 INFO - missing file: chrome://extensions/content/schemas/manifest/icons referenced from chrome://extensions/content/schemas/management.json
[task 2019-01-20T20:11:13.130Z] 20:11:13 INFO - missing file: chrome://extensions/content/schemas/events#filtered referenced from chrome://extensions/content/schemas/events.json
[task 2019-01-20T20:11:13.132Z] 20:11:13 INFO - missing file: chrome://extensions/content/schemas/extension.html#property-lastError referenced from chrome://extensions/content/schemas/downloads.json
[task 2019-01-20T20:11:13.133Z] 20:11:13 INFO - missing file: chrome://global/skin/plugins.css referenced from chrome://global/content/plugins.html
[task 2019-01-20T20:11:13.134Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/aboutPlugins.ftl referenced from chrome://global/content/plugins.html
[task 2019-01-20T20:11:13.137Z] 20:11:13 INFO - missing file: chrome://global/content/crashreporter/aboutcrashes.ftl referenced from chrome://global/content/crashes.xhtml
[task 2019-01-20T20:11:13.137Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/aboutAbout.ftl referenced from chrome://global/content/aboutAbout.xhtml
[task 2019-01-20T20:11:13.138Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/url-classifier.ftl referenced from chrome://global/content/aboutUrlClassifier.xhtml
[task 2019-01-20T20:11:13.138Z] 20:11:13 INFO - missing file: chrome://global/content/branding/brand.ftl referenced from chrome://global/content/aboutSupport.xhtml,chrome://global/content/aboutServiceWorkers.xhtml
[task 2019-01-20T20:11:13.139Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/aboutSupport.ftl referenced from chrome://global/content/aboutSupport.xhtml
[task 2019-01-20T20:11:13.142Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/aboutProfiles.ftl referenced from chrome://global/content/aboutProfiles.xhtml
[task 2019-01-20T20:11:13.144Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/aboutNetworking.ftl referenced from chrome://global/content/aboutNetworking.xhtml
[task 2019-01-20T20:11:13.144Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/aboutServiceWorkers.ftl referenced from chrome://global/content/aboutServiceWorkers.xhtml
[task 2019-01-20T20:11:13.145Z] 20:11:13 INFO - missing file: chrome://global/content/toolkit/about/aboutPerformance.ftl referenced from chrome://global/content/aboutPerformance.xhtml
[task 2019-01-20T20:11:13.146Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/applicationManager.ftl referenced from chrome://browser/content/preferences/applicationManager.xul
[task 2019-01-20T20:11:13.147Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/siteDataSettings.css referenced from chrome://browser/content/preferences/siteDataRemoveSelected.xul,chrome://browser/content/preferences/siteDataSettings.xul
[task 2019-01-20T20:11:13.148Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/siteDataSettings.ftl referenced from chrome://browser/content/preferences/siteDataRemoveSelected.xul,chrome://browser/content/preferences/siteDataSettings.xul
[task 2019-01-20T20:11:13.151Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/branding/sync-brand.ftl referenced from chrome://browser/content/preferences/in-content/syncDisconnect.xul,chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.152Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/syncDisconnect.ftl referenced from chrome://browser/content/preferences/in-content/syncDisconnect.xul
[task 2019-01-20T20:11:13.153Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/fonts.ftl referenced from chrome://browser/content/preferences/fonts.xul
[task 2019-01-20T20:11:13.154Z] 20:11:13 INFO - missing file: chrome://browser/content/branding/brand.ftl referenced from chrome://browser/content/aboutDialog.xul,chrome://browser/content/aboutSessionRestore.xhtml,chrome://browser/content/aboutWelcomeBack.xhtml,chrome://browser/content/aboutRestartRequired.xhtml
[task 2019-01-20T20:11:13.155Z] 20:11:13 INFO - missing file: chrome://browser/content/browser/aboutDialog.ftl referenced from chrome://browser/content/aboutDialog.xul
[task 2019-01-20T20:11:13.156Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/preferences.ftl referenced from chrome://browser/content/preferences/sitePermissions.xul,chrome://browser/content/preferences/connection.xul
[task 2019-01-20T20:11:13.158Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/permissions.ftl referenced from chrome://browser/content/preferences/sitePermissions.xul,chrome://browser/content/preferences/permissions.xul
[task 2019-01-20T20:11:13.161Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/connection.ftl referenced from chrome://browser/content/preferences/connection.xul
[task 2019-01-20T20:11:13.162Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/branding/brand.ftl referenced from chrome://browser/content/preferences/connection.xul,chrome://browser/content/preferences/siteDataSettings.xul,chrome://browser/content/preferences/clearSiteData.xul,chrome://browser/content/preferences/blocklists.xul,chrome://browser/content/preferences/browserLanguages.xul,chrome://browser/content/preferences/sanitize.xul
[task 2019-01-20T20:11:13.163Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/languages.ftl referenced from chrome://browser/content/preferences/languages.xul,chrome://browser/content/preferences/browserLanguages.xul
[task 2019-01-20T20:11:13.164Z] 20:11:13 INFO - missing file: chrome://browser/content/browser/sanitize.ftl referenced from chrome://browser/content/sanitize.xul
[task 2019-01-20T20:11:13.165Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/clearSiteData.ftl referenced from chrome://browser/content/preferences/clearSiteData.xul
[task 2019-01-20T20:11:13.167Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/containers.ftl referenced from chrome://browser/content/preferences/containers.xul
[task 2019-01-20T20:11:13.168Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/colors.ftl referenced from chrome://browser/content/preferences/colors.xul
[task 2019-01-20T20:11:13.169Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/blocklists.ftl referenced from chrome://browser/content/preferences/blocklists.xul
[task 2019-01-20T20:11:13.170Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/branding/brand.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.172Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/preferences.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.173Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/fonts.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.175Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/blocklists.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.176Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/clearSiteData.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.177Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/colors.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.178Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/connection.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.179Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/languages.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.181Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/permissions.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.183Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/selectBookmark.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.184Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/siteDataSettings.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.185Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/aboutDialog.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.187Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/browser/sanitize.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.189Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/toolkit/updates/history.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.190Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/security/certificates/deviceManager.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.192Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/in-content/security/certificates/certManager.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.193Z] 20:11:13 INFO - missing file: chrome://browser/locale/preferences.properties referenced from chrome://browser/content/preferences/in-content/preferences.xul
[task 2019-01-20T20:11:13.196Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/translation.ftl referenced from chrome://browser/content/preferences/translation.xul
[task 2019-01-20T20:11:13.197Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/sanitize.ftl referenced from chrome://browser/content/preferences/sanitize.xul
[task 2019-01-20T20:11:13.198Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/browser/preferences/selectBookmark.ftl referenced from chrome://browser/content/preferences/selectBookmark.xul
[task 2019-01-20T20:11:13.198Z] 20:11:13 INFO - missing file: resource://gre/modules/SimpleServiceDiscovery.jsm referenced from chrome://browser/content/browser.js
[task 2019-01-20T20:11:13.199Z] 20:11:13 INFO - missing file: resource:///modules/WindowsPreviewPerTab.jsm referenced from chrome://browser/content/browser.js
[task 2019-01-20T20:11:13.199Z] 20:11:13 INFO - missing file: resource:///modules/Windows8WindowFrameColor.jsm referenced from chrome://browser/content/browser.js
[task 2019-01-20T20:11:13.200Z] 20:11:13 INFO - missing file: chrome://browser/content/hiddenWindow.xul referenced from resource://app/defaults/preferences/firefox.js
[task 2019-01-20T20:11:13.200Z] 20:11:13 INFO - missing file: resource://gre/localization/%7Blocale%7D/ referenced from resource://app/components/nsBrowserGlue.js
[task 2019-01-20T20:11:13.202Z] 20:11:13 INFO - missing file: resource://app/localization/%7Blocale%7D/ referenced from resource://app/components/nsBrowserGlue.js
[task 2019-01-20T20:11:13.204Z] 20:11:13 INFO - missing file: resource:///modules/AsanReporter.jsm referenced from resource://app/components/nsBrowserGlue.js
[task 2019-01-20T20:11:13.205Z] 20:11:13 INFO - missing file: resource:///modules/WindowsJumpLists.jsm referenced from resource://app/components/nsBrowserGlue.js
[task 2019-01-20T20:11:13.206Z] 20:11:13 INFO - missing file: chrome://branding/content/icon referenced from resource://app/components/nsBrowserGlue.js
[task 2019-01-20T20:11:13.208Z] 20:11:13 INFO - missing file: resource://path/to/file.js referenced from resource://devtools-client-shared/browser-loader-mocks.js
[task 2019-01-20T20:11:13.209Z] 20:11:13 INFO - missing file: chrome://browser/content/pref/pref.xul referenced from resource://app/components/nsBrowserContentHandler.js
[task 2019-01-20T20:11:13.211Z] 20:11:13 INFO - missing file: chrome://browser/content/preferences/preferences.xul referenced from resource://app/components/nsBrowserContentHandler.js
[task 2019-01-20T20:11:13.212Z] 20:11:13 INFO - missing file: chrome://browser/skin/preferences/application.png referenced from chrome://browser/content/preferences/in-content/main.js
[task 2019-01-20T20:11:13.214Z] 20:11:13 INFO - missing file: resource://test/ referenced from resource://devtools/shared/worker/loader.js,resource://devtools/shared/Loader.jsm
[task 2019-01-20T20:11:13.215Z] 20:11:13 INFO - missing file: resource://app/some/link.html referenced from resource://devtools-client-shared/node-attribute-parser.js
[task 2019-01-20T20:11:13.216Z] 20:11:13 INFO - missing file: resource://testing-common/content-task.js%20line%2059%20%3E%20eval referenced from resource://devtools/client/webconsole/test/fixtures/stubs/pageError.js
[task 2019-01-20T20:11:13.217Z] 20:11:13 INFO - missing file: resource:///modules/policies/WindowsGPOParser.jsm referenced from resource://app/components/EnterprisePolicies.js
[task 2019-01-20T20:11:13.217Z] 20:11:13 INFO - missing file: resource:///modules/policies/macOSPoliciesParser.jsm referenced from resource://app/components/EnterprisePolicies.js
[task 2019-01-20T20:11:13.218Z] 20:11:13 INFO - missing file: resource://modules/PlacesUtils.jsm referenced from resource://app/modules/UrlbarProvidersManager.jsm
[task 2019-01-20T20:11:13.219Z] 20:11:13 INFO - missing file: chrome://browser/content/extension-mac-panel.css referenced from resource://app/modules/ExtensionPopups.jsm
[task 2019-01-20T20:11:13.220Z] 20:11:13 INFO - missing file: chrome://browser/content/extension-win-panel.css referenced from resource://app/modules/ExtensionPopups.jsm
[task 2019-01-20T20:11:13.221Z] 20:11:13 INFO - missing file: chrome://browser/content/aboutconfig/browser/aboutConfig.ftl referenced from chrome://browser/content/aboutconfig/aboutconfig.html
[task 2019-01-20T20:11:13.222Z] 20:11:13 INFO - missing file: chrome://browser/content/browser/aboutSessionRestore.ftl referenced from chrome://browser/content/aboutSessionRestore.xhtml,chrome://browser/content/aboutWelcomeBack.xhtml
[task 2019-01-20T20:11:13.223Z] 20:11:13 INFO - missing file: chrome://browser/content/browser/aboutRestartRequired.ftl referenced from chrome://browser/content/aboutRestartRequired.xhtml
[task 2019-01-20T20:11:13.224Z] 20:11:13 INFO - missing file: chrome://browser/content/policies/branding/brand.ftl referenced from chrome://browser/content/policies/aboutPolicies.xhtml
[task 2019-01-20T20:11:13.225Z] 20:11:13 INFO - missing file: chrome://browser/content/policies/browser/branding/sync-brand.ftl referenced from chrome://browser/content/policies/aboutPolicies.xhtml
[task 2019-01-20T20:11:13.225Z] 20:11:13 INFO - missing file: chrome://browser/content/policies/browser/aboutPolicies.ftl referenced from chrome://browser/content/policies/aboutPolicies.xhtml
[task 2019-01-20T20:11:13.227Z] 20:11:13 INFO - missing file: chrome://browser/content/policies/browser/policies/policies-descriptions.ftl referenced from chrome://browser/content/policies/aboutPolicies.xhtml
[task 2019-01-20T20:11:13.228Z] 20:11:13 INFO - missing file: resource://screenshots-addon/ referenced from jar:file:///builds/worker/workspace/build/application/firefox/browser/features/screenshots@mozilla.org.xpi!/background/senderror.js
[task 2019-01-20T20:11:13.244Z] 20:11:13 INFO - Leaving test bound checkAllTheFiles
[task 2019-01-20T20:11:13.248Z] 20:11:13 INFO - Console message: No chrome package registered for chrome://help/content/help.js
[task 2019-01-20T20:11:13.250Z] 20:11:13 INFO - Console message: No chrome package registered for chrome://gfxsanity/content/sanityparent.html
[task 2019-01-20T20:11:13.268Z] 20:11:13 INFO - GECKO(1528) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-01-20T20:11:13.270Z] 20:11:13 INFO - GECKO(1528) | MEMORY STAT | vsize 981MB | residentFast 677MB | heapAllocated 468MB
[task 2019-01-20T20:11:13.272Z] 20:11:13 INFO - TEST-OK | browser/base/content/test/static/browser_all_files_referenced.js | took 9984ms

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a5b887c68abdec7fa7ba0d43565dfdb6527d3f48

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eecfa033212f039285ae0dfca9299af2a963c92

Flags: needinfo?(ryanvm)

I think the right thing to do here is to just add an exception to the test for this file. The upstream commit lays out the reason for including it at all still:
https://github.com/mozilla/pdf.js/commit/480110625ab1e9b256a4e677b6a69d046f4154ac

Basically, ReadableStream is still disablable via pref, so it's better to have the polyfill there if needed. However, it generally won't be loaded at all for regular users. Mike, does that sound like sane reasoning to you too?

Flags: needinfo?(ryanvm) → needinfo?(mconley)

Tentatively, yes, it does - though is there a timeline to remove that polyfill / whitelist entry? I think that'd be my only concern here - that we don't forget about actually removing this thing. We should get a bug on file to do that work, and then probably reference it from the whitelist entry.

Flags: needinfo?(mconley) → needinfo?(ryanvm)

Jason, do you know if/when we intend to remove the pref for ReadableStream?

Flags: needinfo?(ryanvm) → needinfo?(jorendorff)

It's also a question of support. As we're all well aware, we have a ton of about:config flags that, if fiddled, will absolutely break various things. So the question is - how much do we want to support the disabled stream case? If we reach a point where we really don't want to support that case, then the polyfill is probably at the point where it can be dropped. If that point is now, we can probably drop it now.

I forgot it was there.

We're keeping streams, and I don't know of any use case for disabling them (?), so please consider the no-streams case unsupported.

Flags: needinfo?(jorendorff)

Jonas, are you OK with removing the polyfill outright for MOZCENTRAL builds?

Flags: needinfo?(jonas.jenwald)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

Basically, ReadableStream is still disablable via pref, so it's better to have the polyfill there if needed.

Just to clarify: Unless ReadableStream is available somehow, be it natively or polyfilled, the PDF Viewer will be completely broken.

(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)

Tentatively, yes, it does - though is there a timeline to remove that polyfill / whitelist entry? I think that'd be my only concern here - that we don't forget about actually removing this thing.

Another small clarification: Please note that the polyfill is currently included twice in Firefox, since it's bundled into two separate files; see browser/extensions/pdfjs/content/build/pdf.js#2578 respectively browser/extensions/pdfjs/content/build/pdf.worker.js#3215.

The changes in this bug would simply reduce that to just one copy in total, and the polyfill will not even be loaded by default unless the javascript.options.streams preference is false.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Jonas, are you OK with removing the polyfill outright for MOZCENTRAL builds?

Given comment 6 and comment 7 in particular, and also bug 1522136, personally I think I'd be OK with a complete removal at this point.
(Although we should probably at least add a warning, referencing the pref, in the PDF.js code.)

However, I'm not sure if this is ultimately my call though!?

Flags: needinfo?(jonas.jenwald)

(In reply to Jonas Jenwald [:Snuffleupagus] from comment #9)

However, I'm not sure if this is ultimately my call though!?

Brendan's the only active module peer left for pdf.js - can you please rubberstamp this?

(On on a related note - https://wiki.mozilla.org/Modules/All#PDF badly needs updates)

Flags: needinfo?(bdahl)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)

(In reply to Jonas Jenwald [:Snuffleupagus] from comment #9)

However, I'm not sure if this is ultimately my call though!?

Brendan's the only active module peer left for pdf.js - can you please rubberstamp this?

Yeah, let's remove for moz central builds. Someone disabling streams seems like strange corner case that we don't need to support.

(On on a related note - https://wiki.mozilla.org/Modules/All#PDF badly needs updates)

Yes, mossop had whole bunch of updates for that. I'm not sure when it's going through though.

Flags: needinfo?(bdahl)

(In reply to Brendan Dahl [:bdahl] from comment #11)

Yeah, let's remove for moz central builds. Someone disabling streams seems
like strange corner case that we don't need to support.

Thanks, Brendan. Looks like we're good to proceed with outright removal, Jonas :-)

Flags: needinfo?(jonas.jenwald)

Changes since last update:
#10480 [Regression] Fix the FontInspector in the PDFBug debugging tools
#10483 Update the mobile-viewer example to use the new PDFHistory.initialize format (PR 10423 follow-up)
#10484 Stop bundling the ReadableStream polyfill in MOZCENTRAL builds (PR 10470 follow-up)

Flags: needinfo?(jonas.jenwald)
Summary: Update pdf.js to version 2.1.209 → Update pdf.js to version 2.1.215
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/616df32dc42d Update pdf.js to version 2.1.215. r=bdahl

https://hg.mozilla.org/mozilla-central/rev/616df32dc42d

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Blocks: 1523300
No longer blocks: 1523300
Blocks: pdfjs-updates
No longer depends on: 1521182
Type: defect → task
You need to log in before you can comment on or make changes to this bug.