1521427 - Display the doorhanger notification for unsupported type update notifications

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Robert Strong (they/them - no direct email)]

This was overlooked and not implemented during when doorhangers were implemented.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: screenshot - old ui for unsupported

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: screenshot - unsupported about window

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: screenshot - doorhanger, badge, and hamburger menu item

Comment 4

[Robert Strong (they/them - no direct email)]

Bram, since you worked on the update doorhanger implementation can you perform the UX review of this update doorhanger implementation? Thanks!

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad183556a1c77610072aaccead2ca4f113965df1

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: screenshot - hamburger menu item alt text

Comment 8

[Robert Strong (they/them - no direct email)]

I propose something along the lines of the following behavior

Client checks for updates and the update advertisement states that their system is no longer supported.
The doorhanger notification is displayed with two buttons.
The first button ("Learn More") closes the doorhanger and opens a web page providing details of why their system is no longer supported along with what they can do to resolve this.
The second button ("Not Now" or similar) closes the doorhanger.
In both cases the badge on the hamburger menu is displayed after a button is clicked.
If the hamburger menu is clicked the unsupported menu item will be displayed.
If the unsupported menu item under the hamburger menu is clicked the same web page is opened providing details of why their system is no longer supported along with what they can do to resolve this.

When Firefox is started again we should persist the unsupported menu item under the hamburger menu.
It needs to be decided whether we should show the doorhanger again.
I think it would be ok to either not show it or only show it if the "Learn More" button was not clicked.

If the client checks for updates and the update advertisement is no longer unsupported the badge and doorhanger are no longer displayed. One use case for this is if the client copies their profile to a new system that is supported.

Comment 9

[Bram Pitoyo [:bram]]

Robert and I discussed this topic yesterday. He will make changes to this bug and resolve it.

Comment 10

[Robert Strong (they/them - no direct email)]

Attachment: screenshot - doorhanger, badge, and hamburger menu item

Bram, attached are the latest screenshots. I used the yellow from addon-install-warning.svg.

Comment 11

[Robert Strong (they/them - no direct email)]

This is going to need a yellow for the dark theme just as bug 1452674 added one for green.

Comment 12

[Bram Pitoyo [:bram]]

Hi Robert,

I’ve given this issue some more thought, and just have one small string modification to offer.

Instead of saying:

Nightly is unable to update to the latest version.

Your Nightly is out of date, but the latest version is not supported on your system.

Maybe we can shorten it, and say:

The latest version of Nightly is not supported on your system.

The about window can still say the same thing:

You cannot perform further updates on this system.

Instead of “Not Now”, maybe we can say “Close”, or even eliminate the “Not Now” action entirely?

The yellow colour for the dark theme can be found here (we use yellow-60 against a light background colour):
https://design.firefox.com/photon/visuals/color.html#yellow

Cancelling Amy’s NI.

Other than these small fixes, the design looks good to me!

Comment 13

[Robert Strong (they/them - no direct email)]

Attachment: screenshot - doorhanger, badge, and hamburger menu item

Hi Bram, I went with the label of "You cannot perform further updates" for the menu item since "You cannot perform further updates on this system" stretched out the menu. The screenshots show the doorhanger with and without a "Close" button. I do slightly prefer having the close button since it isn't obvious how to dismiss the doorhanger without it. I found defines for the normal yellow and lwt-popup-brighttext so the colors should be the same as the other uses of yellow.

Comment 14

[Amy Lee [:amylee] UX]

Attachment: Dark Theme - Warning Spec.png

Here's the spec for dark theme. I've noticed that the current icon colour doesn't pass contrast tests (in default theme). Can you please update the icon colour for both light/dark themes. I will attached a light theme spec as well. I've updated the highlight colour so it's a Photon colour.

Comment 15

[Amy Lee [:amylee] UX]

Attachment: Default Theme - Warning Spec.png

Default theme

Comment 16

[Amy Lee [:amylee] UX]

This icon colour should also be updated in the door-hangers as well. Thanks!

Comment 17

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

This has the css set to the color values provided

Comment 18

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Discussed this on slack with Amy and for this bug we're going to go with the default colors defined in panelUI.inc.css. The changing of the colors can be done in a new bug since it affects more than just the UI that is being added here.

Comment 19

[Bram Pitoyo [:bram]]

Thanks heaps Amy for posting the design specs!

(In reply to Robert Strong (Robert he/him) [:rstrong] (use needinfo to contact me) from comment #13)

Hi Bram, I went with the label of "You cannot perform further updates" for the menu item since "You cannot perform further updates on this system" stretched out the menu.

The menu item string sounds good.

The doorhanger string also sounds good.

And when read side by side, the menu item, the doorhanger and the about window now contains the same message.

The screenshots show the doorhanger with and without a "Close" button. I do slightly prefer having the close button since it isn't obvious how to dismiss the doorhanger without it.

Yes. This looks good.

Comment 20

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1521427 - Display the doorhanger notification for unsupported type update notifications. r=bytesized

The unsupported doorhanger will persist the menu item across application restarts until an update has been found.

Comment 21

[Robert Strong (they/them - no direct email)]

tdsmith, the original data review happened in bug 893505 and it looks like it happened in bug 893505 comment #156 with approval in bug 893505 comment 190

Comment 22

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Attachment: Data collection review

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c0d9bd9f398
Display the doorhanger notification for unsupported type update notifications. r=bytesized,flod,zbraniecki

Comment 24

[Robert Strong (they/them - no direct email)]

Filed bug 1549780 to update app update telemetry probes to add a second email and secondary bugs numbers for probes

Comment 25

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6c0d9bd9f398