Display the doorhanger notification for unsupported type update notifications

RESOLVED FIXED in Firefox 68

Status

()

defect
P1
normal
RESOLVED FIXED
5 months ago
2 months ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

(Depends on 1 bug)

59 Branch
mozilla68
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(8 attachments, 5 obsolete attachments)

48.23 KB, image/png
Details
216.03 KB, image/png
Details
211.30 KB, image/png
Details
119.69 KB, image/png
Details
100.39 KB, image/png
Details
26.35 KB, patch
Details | Diff | Splinter Review
47 bytes, text/x-phabricator-request
Details | Review
1.52 KB, text/plain
tdsmith
: data-review+
Details

This was overlooked and not implemented during when doorhangers were implemented.

Bram, since you worked on the update doorhanger implementation can you perform the UX review of this update doorhanger implementation? Thanks!

Flags: needinfo?(bram)

I propose something along the lines of the following behavior

Client checks for updates and the update advertisement states that their system is no longer supported.
The doorhanger notification is displayed with two buttons.
The first button ("Learn More") closes the doorhanger and opens a web page providing details of why their system is no longer supported along with what they can do to resolve this.
The second button ("Not Now" or similar) closes the doorhanger.
In both cases the badge on the hamburger menu is displayed after a button is clicked.
If the hamburger menu is clicked the unsupported menu item will be displayed.
If the unsupported menu item under the hamburger menu is clicked the same web page is opened providing details of why their system is no longer supported along with what they can do to resolve this.

When Firefox is started again we should persist the unsupported menu item under the hamburger menu.
It needs to be decided whether we should show the doorhanger again.
I think it would be ok to either not show it or only show it if the "Learn More" button was not clicked.

If the client checks for updates and the update advertisement is no longer unsupported the badge and doorhanger are no longer displayed. One use case for this is if the client copies their profile to a new system that is supported.

Blocks: 1515484

Robert and I discussed this topic yesterday. He will make changes to this bug and resolve it.

Flags: needinfo?(bram)

Bram, attached are the latest screenshots. I used the yellow from addon-install-warning.svg.

Attachment #9037883 - Attachment is obsolete: true
Attachment #9037892 - Attachment is obsolete: true
Attachment #9043079 - Flags: ui-review?(bram)

This is going to need a yellow for the dark theme just as bug 1452674 added one for green.

Flags: needinfo?(amlee)

Comment 12

4 months ago

Hi Robert,

I’ve given this issue some more thought, and just have one small string modification to offer.

Instead of saying:

Nightly is unable to update to the latest version.

Your Nightly is out of date, but the latest version is not supported on your system.

Maybe we can shorten it, and say:

The latest version of Nightly is not supported on your system.

The about window can still say the same thing:

You cannot perform further updates on this system.

Instead of “Not Now”, maybe we can say “Close”, or even eliminate the “Not Now” action entirely?

The yellow colour for the dark theme can be found here (we use yellow-60 against a light background colour):
https://design.firefox.com/photon/visuals/color.html#yellow

Cancelling Amy’s NI.

Other than these small fixes, the design looks good to me!

Flags: needinfo?(amlee)

Hi Bram, I went with the label of "You cannot perform further updates" for the menu item since "You cannot perform further updates on this system" stretched out the menu. The screenshots show the doorhanger with and without a "Close" button. I do slightly prefer having the close button since it isn't obvious how to dismiss the doorhanger without it. I found defines for the normal yellow and lwt-popup-brighttext so the colors should be the same as the other uses of yellow.

Attachment #9043079 - Attachment is obsolete: true
Attachment #9043079 - Flags: ui-review?(bram)
Attachment #9043191 - Flags: ui-review?(bram)

Here's the spec for dark theme. I've noticed that the current icon colour doesn't pass contrast tests (in default theme). Can you please update the icon colour for both light/dark themes. I will attached a light theme spec as well. I've updated the highlight colour so it's a Photon colour.

Default theme

This icon colour should also be updated in the door-hangers as well. Thanks!

Posted patch patch in progress (obsolete) — Splinter Review

This has the css set to the color values provided

Attachment #9037884 - Attachment is obsolete: true

Discussed this on slack with Amy and for this bug we're going to go with the default colors defined in panelUI.inc.css. The changing of the colors can be done in a new bug since it affects more than just the UI that is being added here.

Attachment #9043345 - Attachment is obsolete: true

Thanks heaps Amy for posting the design specs!

(In reply to Robert Strong (Robert he/him) [:rstrong] (use needinfo to contact me) from comment #13)

Hi Bram, I went with the label of "You cannot perform further updates" for the menu item since "You cannot perform further updates on this system" stretched out the menu.

The menu item string sounds good.

The doorhanger string also sounds good.

And when read side by side, the menu item, the doorhanger and the about window now contains the same message.

The screenshots show the doorhanger with and without a "Close" button. I do slightly prefer having the close button since it isn't obvious how to dismiss the doorhanger without it.

Yes. This looks good.

Updated

4 months ago
Attachment #9043191 - Flags: ui-review?(bram) → ui-review+

The unsupported doorhanger will persist the menu item across application restarts until an update has been found.

Type: enhancement → defect

tdsmith, the original data review happened in bug 893505 and it looks like it happened in bug 893505 comment #156 with approval in bug 893505 comment 190

Flags: needinfo?(tdsmith)
Flags: needinfo?(tdsmith)
Attachment #9063263 - Flags: data-review+

Comment 23

2 months ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c0d9bd9f398
Display the doorhanger notification for unsupported type update notifications. r=bytesized,flod,zbraniecki

Filed bug 1549780 to update app update telemetry probes to add a second email and secondary bugs numbers for probes

Comment 25

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.