Add webdriver unit tests for indefinite script timeout

RESOLVED FIXED in Firefox 67

Status

enhancement
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: r2hkri, Assigned: r2hkri)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Follow-up to 1128997

> The only thing I actually miss in this patch are some more unit tests for the
> webdriver crate. I don't want to run wdspec to verify if changes in
> webdriver/geckodriver work. Running the Rust unittest is way less expensive.
> Would you mind getting those tests added in a follow-up bug?
> Just create one and upload the new patch. I would appreciate and be happy to
> review it.

Add unit tests to cover webdriver functionality that was suggested and implemented in linked bug (difference between undefined and null when serializing and de-serializing script timeout values).

Can you be more specific in the description what test you are going
to add here? Otherwise I fear we risk scope creep.

Component: Marionette → geckodriver

Thank you for filing this bug. Do you also want to work on it, and add the remaining tests?

Summary: Add webdriver unit tests to increase coverage → Add webdriver unit tests for indefinite script timeout

(In reply to Andreas Tolfsen ⦗:ato⦘ from comment #1)

Can you be more specific in the description what test you are going
to add here? Otherwise I fear we risk scope creep.

Test cases that check serializing/deserializing null properly like:

     fn test_json_timeouts_response_with_null_timeout() {
         let json = r#"{"value":{"script":null,"pageLoad":2,"implicit":3}}"#;
         let data = WebDriverResponse::Timeouts(TimeoutsResponse::new(None, 2, 3));
         check_serialize(&json, &data);
     }

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #2)

Thank you for filing this bug. Do you also want to work on it, and add the remaining tests?

Yes, I can work on it.

Add tests that check serialization and deserialization for indefinite script timeout

Assignee: nobody → r2hkri
Blocks: 1495062
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/590f9a6f20a5
Add webdriver unit tests for indefinite script timeout. r=whimboo
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.