1521476 - Crash in java.lang.IllegalStateException: at org.mozilla.gecko.GeckoApplication.createShortcut(GeckoApplication.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Gabriele Svelto [:gsvelto]]

This bug is for crash report bp-08f37420-1192-4e91-b9ca-5c4590190120.

Java stack trace:

java.lang.IllegalStateException
	at org.mozilla.gecko.GeckoApplication.createShortcut(GeckoApplication.java:684)
	at org.mozilla.gecko.GeckoApplication.createShortcut(GeckoApplication.java:661)
	at org.mozilla.gecko.toolbar.PwaConfirm$2.onClick(PwaConfirm.java:124)
	at android.view.View.performClick(View.java:6897)
	at android.widget.TextView.performClick(TextView.java:12693)
	at android.view.View$PerformClick.run(View.java:26101)
	at android.os.Handler.handleCallback(Handler.java:789)
	at android.os.Handler.dispatchMessage(Handler.java:98)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6944)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

The unredacted exception is:

java.lang.IllegalStateException: This page is not safe for PWA

This is one of the URLs mentioned in the crashes:

https://www.independent.co.uk/life-style/gadgets-and-tech/news/radio-signals-fast-radio-bursts-frbs-galaxy-signal-repeated-space-scientists-a8719886.html

Comment 1

[Andrei Lazar]

Attachment: Bug 1521476 Crash in java.lang.IllegalStateException: at org.mozilla.gecko.GeckoApplication.createShortcut(GeckoApplication.java) r=sdaswani

Removed intended throw of IllegalStateException for Nightly when a page was not considered safe as a PWA.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/903ca27a7aed
Crash in java.lang.IllegalStateException: at org.mozilla.gecko.GeckoApplication.createShortcut(GeckoApplication.java) r=petru

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/903ca27a7aed