Closed
Bug 1521524
Opened 5 years ago
Closed 5 years ago
Improve our GC reason codes
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
1.28 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
|
8.83 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
We should remove unused GCReasons and add new ones where appropriate so we can improve our understanding of why GCs are being triggered. I'm seeing quite a lot of 'API' reasons in testing, which isn't all that useful.
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 1•5 years ago
|
||
Remove some unused reason codes.
Attachment #9037991 -
Flags: review?(sphink)
|
|
Assignee | |
Comment 2•5 years ago
|
||
This tries to cut down on the number of 'API' reasons, except for those in test code and the shell.
Attachment #9037993 -
Flags: review?(sphink)
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9037993 [details] [diff] [review] bug1521524-add-new-reasons Review of attachment 9037993 [details] [diff] [review]: ----------------------------------------------------------------- Yes! (Though I wonder if the default of API should even be offered.)
Attachment #9037993 -
Flags: review?(sphink) → review+
|
|
||
Updated•5 years ago
|
Attachment #9037991 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/868210b65236 Remove some unused GC reasons r=sfink https://hg.mozilla.org/integration/mozilla-inbound/rev/296ce3f773e9 Replace some uses of the 'API' GC reason with more informative ones r=sfink
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/868210b65236
https://hg.mozilla.org/mozilla-central/rev/296ce3f773e9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•