Closed
Bug 1521575
Opened 5 years ago
Closed 5 years ago
Move nsSMILTimeValue classes and nsSMILInstanceTime to the mozilla namespace
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(1 file)
101.96 KB,
patch
|
birtles
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee: nobody → longsonr
Attachment #9038013 -
Flags: review?(bbirtles)
Comment 2•5 years ago
|
||
Comment on attachment 9038013 [details] [diff] [review] patch Review of attachment 9038013 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/smil/SMILTimeValueSpec.h @@ +23,1 @@ > namespace dom { Maybe this is a clang-format thing we can't change, but I'd personally find this a little easier if we had a blank line before `namespace dom {`. (Likewise, after `namespace mozilla {` further up now that we're no longer using it purely for forward declarations.) ::: dom/smil/SMILTimedElement.h @@ +31,3 @@ > namespace dom { > class SVGAnimationElement; > } // namespace dom As before, I'd personally find this a little easier to follow as: ``` namespace mozilla { class SMILAnimationFunction; class SMILTimeContainer; class SMILTimeValue; namespace dom { class SVGAnimationElement; } // namespace dom ``` particularly now that the `namespace mozilla {` part is being used for more than just forward declarations. ::: dom/smil/nsSMILTypes.h @@ +19,4 @@ > // wallclock time -- "real" time -- offset since the epoch > // > // For an overview of how this class is related to other SMIL time classes see > +// the documentstation in SMILTimeValue.h Perhaps we can fix documentstation at the same time ;)
Attachment #9038013 -
Flags: review?(bbirtles) → review+
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d358a9083413 Move nsSMILTimeValue classes and nsSMILInstanceTime to the mozilla namespace r=birtles
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Comment 5•5 years ago
|
||
https://hg.mozilla.org/projects/cedar/rev/d358a9083413cb023f6875a8432ead7bafa1f1d2 Bug 1521575 - Move nsSMILTimeValue classes and nsSMILInstanceTime to the mozilla namespace r=birtles
You need to log in
before you can comment on or make changes to this bug.
Description
•