1521605 - 2/3 width Hero has text and image in reverse order to the spec

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Tim Spurway [:tspurway]]

Attachment: Hero

In the spec (https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Modules?node-id=9%3A15) the order is text, then image from left to right. This is reversed in the implementation (see attached).

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4712

Comment 2

[Ed Lee :Mardak]

This landed in https://github.com/mozilla/activity-stream/commit/69be66451ac3959b5b799832ac5c02fbc6edad16 but did not have the bug number in the commit message.

"setting proper order for hero img and text in 2/3 layout (#4712)"

Exported in bug 1522752 https://hg.mozilla.org/mozilla-central/rev/9d660bf33923

Comment 3

[Brahmini Nagabandi]

Hi,

Can you pls update QA steps.Thanks

Comment 4

[Gavin Suntop [:gvn] (they/them)]

1. Set browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
2. View Hero at 2/3 layout and confirm that the order is text on left and image on right. (see attached)

Comment 5

[Gavin Suntop [:gvn] (they/them)]

Attachment: proper hero at 2/3