1521606 - Stats not calculated properly for translations with warning

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Matjaz Horvat [:mathjazz]]

Steps to reproduce:

1. Open a string with an approved translation.
2. Override the translation with a new one that has a c-l or pontoon warning.

Expected result: stats show an increase in warnings and decrease in approved strings.

Actual result: stats are unchanged.

--

The bug is in Entity.get_stats() method, which returns the same result for both, stats_before and stats_after:

{u'strings_with_errors_diff': 0, u'fuzzy_strings_diff': 0, u'strings_with_warnings_diff': 0, u'total_strings_diff': 0, u'unreviewed_strings_diff': 0, u'approved_strings_diff': 1}

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1179

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/2d46b88671f6f61464c43177d908663eb2fe5d5d
Fix bug 1521606: Save Errors/Warnings in Translation.save() (#1179)

Saving failed checks must happen before updating stats in Entity.get_stats_diff().