Closed Bug 1521612 Opened 1 year ago Closed 1 year ago

Add pref for combined flexbox highlighter

Categories

(DevTools :: Inspector, enhancement, P2)

enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: miker, Assigned: miker)

Details

Attachments

(1 file)

The combined flexbox highlighter should be disabled if either of the following prefs are false:

  • devtools.inspector.flexboxHighlighter.enabled
  • devtools.inspector.flexboxHighlighter.combine

devtools.inspector.flexboxHighlighter.combine should be true in dev edition and false in release.

Because checking for prefs is slow and performance is paramount for the highlighter we cache the result. Because we cache the result the Toolbox needs to be closed and opened again for any pref changes to take affect.

Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b038cb88e341
Add pref for combined flexbox highlighter r=pbro
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Assignee: nobody → mratcliffe
Flags: qe-verify+
QA Contact: cristian.comorasu
Flags: qe-verify+
QA Contact: cristian.comorasu
You need to log in before you can comment on or make changes to this bug.