1521629 - Port search() to UrlbarInput.jsm

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

Bug 1480503 added the search() function (for search shortcuts) to urlbarBindings.xml but that's going away. That code needs to be ported to UrlbarInput.jsm.

Comment 1

[Dão Gottwald [:dao]]

Would be nice to unify this with typeRestrictToken. The differences seem somewhat arbitrary.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

I thought this would be quick to do but, after looking at it, I realize it depends on things in in UrlbarInput.jsm yet.

Comment 3

[Dão Gottwald [:dao]]

What things specifically?

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Dão Gottwald [::dao] from comment #3)

What things specifically?

The first things I ran into were this.whichSearchSuggestionsNotification and this.popup. I'm not very familiar with everything going on there but I'm willing to help out with some guidance.

Comment 5

[Dão Gottwald [:dao]]

The search suggestion notification isn't implemented yet, so that whole block can be disregarded for now. It doesn't seem crucial to the main purpose of this method.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

In that case, I'll have a patch shortly :)

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Bug 1521629 - Port search() to UrlbarInput.jsm

MozReview-Commit-ID: 70RV8IdoAKc

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b4294b58904
Port search() to UrlbarInput.jsm r=dao

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5b4294b58904