Port search() to UrlbarInput.jsm

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P1
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: rrosario, Assigned: rrosario)

Tracking

(Blocks 1 bug)

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Bug 1480503 added the search() function (for search shortcuts) to urlbarBindings.xml but that's going away. That code needs to be ported to UrlbarInput.jsm.

Assignee

Updated

5 months ago
Blocks: 1480503
No longer blocks: 1514352

Would be nice to unify this with typeRestrictToken. The differences seem somewhat arbitrary.

Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P2
Assignee

Updated

5 months ago
Assignee: nobody → rrosario
Priority: P2 → P1

I thought this would be quick to do but, after looking at it, I realize it depends on things in in UrlbarInput.jsm yet.

Assignee: rrosario → nobody
Iteration: 67.1 - Jan 28 - Feb 10 → ---
Component: Activity Streams: Newtab → Address Bar

What things specifically?

Flags: needinfo?(rrosario)

(In reply to Dão Gottwald [::dao] from comment #3)

What things specifically?

The first things I ran into were this.whichSearchSuggestionsNotification and this.popup. I'm not very familiar with everything going on there but I'm willing to help out with some guidance.

Flags: needinfo?(rrosario)

The search suggestion notification isn't implemented yet, so that whole block can be disregarded for now. It doesn't seem crucial to the main purpose of this method.

In that case, I'll have a patch shortly :)

Assignee: nobody → rrosario

MozReview-Commit-ID: 70RV8IdoAKc

Comment 8

5 months ago
Pushed by rrosario@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b4294b58904
Port search() to UrlbarInput.jsm r=dao

Comment 9

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.