1521688 - Missing window controls (minimize, maximize and close buttons) on a window opened via window.open() with "toolbar", without "menubar", when the menu bar is configured as always shown

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[YUKI "Piro" Hiroshi]

Attachment: missing-window-controls.png

Steps to reproduce:

1. Start Firefox on a Windows PC.
2. Right-click on the toolbar and check "Menu Bar" to show it always.
3. Hit Ctrl-Shift-K to open the Web Console.
4. Input window.open('about:blank','_blank','toolbar') and hit Enter key.
5. The popup is blocked by Firefox's popup blocker, thus click the "allow to open
   the requested window.

Actual result:

A browser window is opened without window controls.
(See the attached screenshot: missing-window-controls.png)

Expected result:

A browser window is opened with window controls.

Envrionment:

• Confirmed versions of Firefox
  • Firefox 65.0b12 (build ID: 20190117232427)
  • Nightly 66.0a1 (build ID: 20190121175139)
• Confirmed platform
  • Windows 7
  • Windows 10

Additional information:

• If you uncheck the "Menu Bar" to show it on demand, the opened window has window controls. This problem appears only with always-shown menu bar.
• On Firefox 64 or older versions, window controls become unclickable if you use the Classic theme of Windows 7, because the #tabbrowser-tab with z-index:2 [1] covers #titlebar-buttonbox with z-index:1 [2].

[1]https://dxr.mozilla.org/mozilla-esr60/source/browser/themes/windows/browser.css#206
[2]https://dxr.mozilla.org/mozilla-esr60/source/browser/themes/windows/browser.css#305

Comment 1

[YUKI "Piro" Hiroshi]

I've filed the bug 1521692 for a similar probelm on currently released Firefox.

Comment 2

[YUKI "Piro" Hiroshi]

Attachment: Patch (WIP)

Initial version patch, without automated test.

I have a question: is there the suitable location to place automated test? I've found possible related tests under:

• https://hg.mozilla.org/mozilla-central/file/tip/browser/base/content/test/
• https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/windowwatcher/test/

Comment 3

[Dão Gottwald [:dao]]

(In reply to YUKI "Piro" Hiroshi from comment #2)

Created attachment 9038164 [details] [diff] [review]
Patch (WIP)

Initial version patch, without automated test.

I have a question: is there the suitable location to place automated test?

https://searchfox.org/mozilla-central/source/browser/base/content/test/popups/browser_popupUI.js

Comment 4

[YUKI "Piro" Hiroshi]

(In reply to Dão Gottwald [::dao] from comment #3)

(In reply to YUKI "Piro" Hiroshi from comment #2)

I have a question: is there the suitable location to place automated test?

https://searchfox.org/mozilla-central/source/browser/base/content/test/popups/browser_popupUI.js

Thanks!

Now I'm trying to write tests. Here is a list of conditions thought as need to be tested:

• browser.tabs.drawInTitlebar (on/off)
• window.open() flags
  • (no feature)
  • toolbar
  • menubar
  • toolbar,menubar
• View => Toolbars => Menu Bar (on/off)

I think https://searchfox.org/mozilla-central/source/toolkit/components/windowwatcher/test/browser_new_content_window_chromeflags.js looks an example for testing with combinations of conditions.

Comment 5

[YUKI "Piro" Hiroshi]

Attachment: Bug 1521688 - Show titlebar buttons when drawInTitlebar=true, window.open with features="toolbar", View => Toolbars => Menu Bar=checked

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d8248d94084
Show titlebar buttons when drawInTitlebar=true, window.open with features="toolbar", View => Toolbars => Menu Bar=checked r=dao

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7d8248d94084