Closed Bug 1521699 Opened 5 years ago Closed 5 years ago

5.09 - 6.19% tsvgx (windows10-64) regression on push 7eac43ea765ebb657f9749a6a8fb2c5c006fae8d (Fri Jan 18 2019)

Categories

(Core :: Graphics, defect, P3)

x86_64
Windows 10
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: igoldan, Unassigned)

References

Details

(Keywords: perf, regression, talos-regression)

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9ac2f47b3cc21276f6d8306175a4f428dcd4378f&tochange=7eac43ea765ebb657f9749a6a8fb2c5c006fae8d

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

6% tsvgx windows10-64 opt e10s stylo 120.27 -> 127.72
5% tsvgx windows10-64 pgo e10s stylo 116.61 -> 122.55

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=18807

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Flags: needinfo?(bas)
Component: General → Graphics
Product: Testing → Core

If there are any blocked bugs which aren't related to this issue, do remove them from the list.

This was more or less expected. Tsvgx is a rather poor test. Tresponsiveness seemed to get a small improvement. The improvement is smaller, but Tresponsiveness is a much more important, and representative test.

Flags: needinfo?(bas)

For the record, we are closely monitoring telemetry to make sure no 'real world' regression is observes from these patches.

Priority: -- → P3

:jwatt you're listed as a contact for the tsvgx test. Can you comment on the value of this test and if we should be concerned with this regression?

Flags: needinfo?(jwatt)
Keywords: stalled

Bas' patches are a trade-off aimed at improving real performance issues. I think we should just accept the regressions for these synthetic Talos tests.

Flags: needinfo?(jwatt)
Keywords: stalled
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.