1521706 - nsIMsgFolder.deleteMessages should notify listener in all cases

Status: RESOLVED FIXED

(MailNews Core :: General, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Some implementations of deleteMessage do nothing with the passed listener in some circumstances, e.g. IMAP when bypassing the trash folder. In order to make bug 1520338 easier, I'm looking into what does and doesn't use the listener, and then making everything use the listener.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1521706-delete-messages-listener-1.diff

That turned out to be easier than expected. I can't see any more implementations of the method.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9038180 [details] [diff] [review]
1521706-delete-messages-listener-1.diff

Review of attachment 9038180 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable. I notice we have a NotifyDeleteOrMoveMessagesCompleted comment but no implementation. Maybe we should remove that, or add a comment there

Comment 3

[Geoff Lankow (:darktrojan)]

It seems to have been superseded by kDeleteOrMoveMsgCompleted. Same goes for NotifyFolderLoaded. I'll remove them.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1521706-unused-methods-1.diff

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/424dfd930d60
When a listener is passed to nsIMsgFolder.deleteMessages, notify it on completion; r=mkmelin
https://hg.mozilla.org/comm-central/rev/e8392f4d3862
Remove commented, unimplemented methods NotifyDeleteOrMoveMessagesCompleted, NotifyFolderLoaded; r=mkmelin

Comment 6

[Geoff Lankow (:darktrojan)]

This broke a bunch of tests in mailnews/db/gloda/test/unit. :(

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8283e69c9dfa
Fix test function not expecting deleteMessages to notify listeners; rs=bustage-fix

Comment 8

[Jorg K (CEST = GMT+2)]

Backed out all three changesets:
https://hg.mozilla.org/comm-central/rev/a497d72c3d8aefee03941b0af2b18b673721ccbc

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/954fd69c1e3c
When a listener is passed to nsIMsgFolder.deleteMessages, notify it on completion; r=mkmelin
https://hg.mozilla.org/comm-central/rev/5565f32e3a87
Remove commented, unimplemented methods NotifyDeleteOrMoveMessagesCompleted, NotifyFolderLoaded; r=mkmelin