Closed
Bug 1521801
Opened 7 years ago
Closed 7 years ago
mark content process crashes as "content" rather than "tab"
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox64 | --- | unaffected |
firefox65 | --- | unaffected |
firefox66 | + | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
1.09 KB,
patch
|
gsvelto
:
review+
|
Details | Diff | Splinter Review |
...as I inadvertently changed the behavior in bug 1514044.
![]() |
Assignee | |
Comment 1•7 years ago
|
||
This is the minimal solution. I didn't fix the other inadvertent change in the
telemetry recording because in the regressing bug, haik and bobowen said it
wasn't a problem for that particular bit to change.
Attachment #9038260 -
Flags: review?(gsvelto)
![]() |
Assignee | |
Comment 2•7 years ago
|
||
It's possible that I really meant to change the enum to use "content" rather than "tab", and that was why we went through the nonsense of asking people if it was OK if telemetry got broken...but given that I screwed things up already, I think the minimal fix is better, especially in soft freeze, and we can go back and make everything "content" later.
Updated•7 years ago
|
tracking-firefox66:
--- → +
Comment 3•7 years ago
|
||
Comment on attachment 9038260 [details] [diff] [review]
fix process type annotation for content process crashes
Let's go with this quick fix, it's the safest option. This is something I should really have spotted during review :(
Attachment #9038260 -
Flags: review?(gsvelto) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/85b9c2b3965f
fix process type annotation for content process crashes; r=gsvelto
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•