1522021 - Propagate input size to CreateSimilarDrawTarget for filters

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

The basic idea here is to add a CreateSimilarDrawTargetForFilter(format, size, FilterNode *filter) that we record instead of CreateSimilarDrawTarget().
When we playback CreateSimilarDrawTargetForFilter we'll do something similar to CreateClippedDrawTarget and compute an actual size that we want to use for the input surface. We do this by adding a method to FilterNode called IntRect MapRectToSource(aRect, aMax). The default implementation of this method returns aMax which is the size passed to CreateSimilarDrawTargetForFilter. Individual FilterNodes can return a rect that is contained by aMax.

FilterNodeComponentTransferSoftware will just call MapRectToSource() on it's inputs. If an input is a SourceSurface we return the rect and so we are able to get a smaller size for when we create the similar draw target.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: A sketch of what this would look like

We end up having to do some gymnastics to build the filter chain before attaching the source, but I think it works out.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Second version

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: A version that builds

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I have this basically working. There's a problem with subpixel offsets making tile borders visible. I'll need to better understand what's going on in ComputeEffectOffset to figure this out.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: A version that works

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Mostly done

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1522021. Propagate input size to CreateSimilarDrawTarget for filters.

This lets us avoid drawing the complete input for ever tile when
drawing filters into a tile.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1522021. Implement SourceSurfaceOffset.

This forwards to an underlying source surface but also has an origin that it
uses to correctly return results from GetRect()

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ae9eadd86a7
Implement SourceSurfaceOffset. r=mstange

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5ae9eadd86a7

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c9634352cd6
Propagate input size to CreateSimilarDrawTarget for filters. r=mstange

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3c9634352cd6