1522028 - Avoid interning text run primitives due to scrolled offset field.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Glenn Watson [:gw]]

In some cases, Gecko may supply a text run with an offset field that changes as the scene is scrolled. When a new display list is sent, this can result in text run primitives being interned when they are otherwise the same.

Instead, make the text run primitive offset field be relative to the primitive origin, to avoid all this extra primitive interning.

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1522028 - Avoid interning text run primitives due to scrolled offset field.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bde038bd2937
Avoid interning text run primitives due to scrolled offset field. r=emilio

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bde038bd2937

Comment 4

[Ionuț Goldan [:igoldan]]

These are the Gecko profiles for tscrollx on Windows 10 Quantum Render (OPT builds):

before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FZTVvX0QNQkqEAx5m_1cqsg%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tscrollx.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FIODXI02gTZy-2RsNwwUWVw%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tscrollx.zip

For tp5o_scroll on Windows 10 Quantum Render (OPT builds):

before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FcX-1oDTVQMmzuPS0XV522A%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tp5o_scroll.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FJc4l1dOMTba4J6D9c2p0-w%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tp5o_scroll.zip

For tscrollx on Linux 64bit Quantum Render (OPT builds):

before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FOXTxPUcBSnyRYNcVBMfNXg%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tscrollx.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FIVoqv5U2TzOnWuakdfn9jA%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tscrollx.zip