1522054 - nsUrlClassifierDBService::Lookup does not exec the callback if the param is systemPrincipal

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Andrea Marchesini [:baku]]

This code seems to be used only for testing, but, this method...

https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#2069-2077

... returns NS_OK, but it doesn't exec the callback if the principal is system, because of this:

https://searchfox.org/mozilla-central/rev/6c784c93cfbd5119ed07773a170b59fbce1377ea/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#2079-2091

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1522054 - Assert when nsUrlClassifierDBService::Lookup is called with SystemPrinciap. r?gcp

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1548ffd8f48c
Assert when nsUrlClassifierDBService::Lookup is called with SystemPrinciap. r=gcp

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 1548ffd8f48c (Bug 1522054) for mochitest failures at test_lookup_system_principal.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/3a1a724d7b7bbe9a3abddb48f6e1229546b07810

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1548ffd8f48ca29f49d1e8f2a92e2cc314c1e12e&selectedJob=274732737

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274732737&repo=autoland&lineNumber=4455

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5df610ae207
Assert when nsUrlClassifierDBService::Lookup is called with SystemPrinciap. r=gcp

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f5df610ae207