1522173 - Bump Cranelift to 0.28

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Upgrade one version, get one free.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 1.bump.patch

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 2.machvendorrust.patch

(output of mach vendor rust)

All tests still passing.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

To wit (in particular a note for Nathan): I urged to do the bump in Spidermonkey to see if having the build script not depend on directories would have an impact in the build time regression we're observing in bug 1506511.

Comment 4

[Dan Gohman [:sunfish]]

Comment on attachment 9038579 [details] [diff] [review]
1.bump.patch

Review of attachment 9038579 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, yes, let's see how much Nathan's patch helps.

Comment 5

[Dan Gohman [:sunfish]]

Comment on attachment 9038580 [details] [diff] [review]
2.machvendorrust.patch

Review of attachment 9038580 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fcfa39da922
Bump Cranelift to 0.28; r=sunfish

Comment 7

[Andreea Pavel [:apavel]]

Backed out for bmsvc build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=223704272&revision=4fcfa39da922a32b0a512f0ac5738912f24ff001

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223704272&repo=mozilla-inbound&lineNumber=4615

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/147153624209097a2ad0af2ecea0e955f57f5aa4

Comment 8

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: bump-rust-nightly.patch

A patch that bumps the version of Rust nightly used in MSVC builds.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eeac181cf4e2294bc2077eebd9fa312350480ada

Comment 9

[Benjamin Bouvier [:bbouvier] (inactive)]

Hi Nathan! The patch above wasn't sufficient: I now get Rust errors because we can't compile SIMD, somehow. I don't want to add more work for you, but just in case: do you have any idea of what a quick fix might be, here?

Comment 10

[Nathan Froyd [:froydnj]]

(In reply to Benjamin Bouvier [:bbouvier] from comment #9)

Hi Nathan! The patch above wasn't sufficient: I now get Rust errors because we can't compile SIMD, somehow. I don't want to add more work for you, but just in case: do you have any idea of what a quick fix might be, here?

I think the right thing here is to somehow see whether aarch64-windows stdlib has made it to the release channel (or beta) and use that version for the aarch64 toolchain instead.

Comment 11

[Benjamin Bouvier [:bbouvier] (inactive)]

Thanks for the suggestion: trying this with 1.32, since the Nightly build error might be bug 1521249, as you said on irc (the logs complained about rustc not being able to compile simd, because of aarch64 intrinsincs not being known).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c293fc5bfd972f345b59212fa2ea2611ae8badfb

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41ef0bc87fd6
Bump Cranelift to 0.28; r=sunfish

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/41ef0bc87fd6