1522213 - Perma Tier2 asan: several tests in encrypt-media SEGV after bug 1519862 got fixed

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=linux%2Cx64%2Casan%2Cweb%2Cplatform%2Ctests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-web-platform-tests-e10s-7%2Cw-e10s%28wpt7%29&selectedJob=223482216&revision=2072956ca0421c3eb1835522546556bb00bf8953

There are several SEGV on Linux asan for encrypt-media, possible that they show up after bug 1519862 got fixed.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/008355f71ca0
disable permafailing encrypted-media tests on linux asan. DONTBUILD

Comment 2

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/008355f71ca0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66d3736fa32e
Backed out changeset 008355f71ca0 because those Linux asan failures in encrypted-media affect more tests and we are gonna disable the whole directory. a=backout
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d64e252185c
Disable encrypt-media tests on Linux x64 asan due to frequent failures. a=test-only

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/5d64e252185c

Comment 5

[Intermittent Failures Robot]

40 failures in 545 pushes (0.073 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 40

Platform breakdown:

• linux64: 40

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1522213&startday=2019-01-24&endday=2019-01-24&tree=all

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I suspect this and bug 1522547 are manifestations of the same issue.

Comment 7

[Intermittent Failures Robot]

40 failures in 2383 pushes (0.017 failures/push) were associated with this bug in the last 7 days.

This is the #31 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 40

Platform breakdown:

• linux64: 40

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1522213&startday=2019-01-21&endday=2019-01-27&tree=all

Comment 8

[Andrew McCreight [:mccr8]]

Do you recall why this patch changed testing/web-platform/meta/websockets/dir.ini? It seems unrelated to the encrypted-media directory.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry that this got into that changeset. That was a leak modification to fix: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&tochange=5d64e252185c4521d414bd197e4159a2971c1617&fromchange=f052949e151b1f2cfd9203a507a94ddd42392ec4&searchStr=wpt7%2Casan&selectedJob=223716749

Comment 10

[Andrew McCreight [:mccr8]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #9)

Sorry that this got into that changeset. That was a leak modification to fix:

Thanks for the explanation. The leak-threshold property only affects debug builds, not ASan, so it wouldn't actually have an effect here. That directly just has a permaleak in it that is being ignored, and the tree herder highlighter just shows it in the log summary. It doesn't actually make the tree orange. I'm probably going to file an issue about cleaning up this file anyways, and I wanted to understand why this file is the way it is.

Comment 11

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I think fixing bug 1522547 should address the issue here: try run. Will put up a patch to re-enable tests.

Comment 12

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1522213 - Re-enable encrypted-media WPT on asan. r?aryx

Bug 1522547 fixed the issue causing these tests to crash on shutdown, which was
also resulting in asan crashes, so these can be re-enabled.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d1df88e93f6
Re-enable encrypted-media WPT on asan. r=aryx

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0d1df88e93f6

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like there are no more failures. Can this bug be closed as fixed now?

Comment 16

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #15)

Looks like there are no more failures. Can this bug be closed as fixed now?

Sounds sensible.

Comment 17

[Intermittent Failures Robot]

1 failures in 4705 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1522213&startday=2019-05-06&endday=2019-05-12&tree=all