Closed Bug 1522213 Opened 7 months ago Closed 5 months ago

Perma Tier2 asan: several tests in encrypt-media SEGV after bug 1519862 got fixed

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox66 disabled, firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox66 --- disabled
firefox67 --- fixed

People

(Reporter: aryx, Assigned: bryce)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/008355f71ca0
disable permafailing encrypted-media tests on linux asan. DONTBUILD
Summary: asan: several tests in encrypt-media SEGV after bug 1519862 got fixed → Perma Tier2 asan: several tests in encrypt-media SEGV after bug 1519862 got fixed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66d3736fa32e
Backed out changeset 008355f71ca0 because those Linux asan failures in encrypted-media affect more tests and we are gonna disable the whole directory. a=backout
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d64e252185c
Disable encrypt-media tests on Linux x64 asan due to frequent failures. a=test-only

I suspect this and bug 1522547 are manifestations of the same issue.

Blocks: 1517595

Do you recall why this patch changed testing/web-platform/meta/websockets/dir.ini? It seems unrelated to the encrypted-media directory.

Flags: needinfo?(aryx.bugmail)

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #9)

Sorry that this got into that changeset. That was a leak modification to fix:

Thanks for the explanation. The leak-threshold property only affects debug builds, not ASan, so it wouldn't actually have an effect here. That directly just has a permaleak in it that is being ignored, and the tree herder highlighter just shows it in the log summary. It doesn't actually make the tree orange. I'm probably going to file an issue about cleaning up this file anyways, and I wanted to understand why this file is the way it is.

Depends on: 1522547

I think fixing bug 1522547 should address the issue here: try run. Will put up a patch to re-enable tests.

Bug 1522547 fixed the issue causing these tests to crash on shutdown, which was
also resulting in asan crashes, so these can be re-enabled.

Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d1df88e93f6
Re-enable encrypted-media WPT on asan. r=aryx

Looks like there are no more failures. Can this bug be closed as fixed now?

Flags: needinfo?(bvandyk)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #15)

Looks like there are no more failures. Can this bug be closed as fixed now?

Sounds sensible.

Status: NEW → RESOLVED
Closed: 5 months ago
Flags: needinfo?(bvandyk)
Keywords: leave-open
Resolution: --- → FIXED
Assignee: nobody → bvandyk
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.