1522253 - newPageInstall should get its FxA endpoint from FxAccounts.config.

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Dave Townsend [:mossop]]

We decided against blocking landing for this, but we really should be using FxAccounts.config to get the Accounts endpoint for the login form. This will probably involve switching to using RemotePageManager to request the endpoint when the page loads.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1522253: Convert RemotePageManager to ES6 classes. r=Gijs

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1522253: Add a standard mechanism for requesting data from the other process. r=Gijs

As we add more specific methods to RemotePageManager some of them will have to
call the main process to get the results. This adds a standard mechanism for
doing so. Calling sendRequest will return a promise that is resolved or rejected
when the main process responds.

Comment 3

[Dave Townsend [:mossop]]

Attachment: Bug 1522253: about:newinstall should get its configuration via RemotePageManager rather than query params. r=Gijs

Comment 4

[Dave Townsend [:mossop]]

The patches here end up adding the service and context parameters to the metrics request (because FxAccounts.config adds them by default: https://searchfox.org/mozilla-central/source/services/fxaccounts/FxAccountsConfig.jsm#73), is that a problem?

Comment 5

[Shane Tomlinson [:stomlinson]]

(In reply to Dave Townsend [:mossop] (he/him) from comment #4)

The patches here end up adding the service and context parameters to the metrics request (because FxAccounts.config adds them by default: https://searchfox.org/mozilla-central/source/services/fxaccounts/FxAccountsConfig.jsm#73), is that a problem?

I just tried from the network console in firefox:

Request URL:https://accounts.firefox.com/metrics-flow?entrypoint=new-install-page&utm_source=new-install-page-release&utm_campaign=dedicated-profiles&form_type=email&service=sync&context=fx_desktop_v3
Request method:GET
Remote address:<xxxx>
Status code:
200
Version:HTTP/1.1

All good.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcc0c69e319e
Convert RemotePageManager to ES6 classes. r=Gijs

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dcc0c69e319e

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a091f6b58aba
Add a standard mechanism for requesting data from the other process. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/5b2aeaf2da17
about:newinstall should get its configuration via RemotePageManager rather than query params. r=Gijs

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1522253) for causing ES Lint failure in newInstallPage.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=5b2aeaf2da17571c8003ecf253df6e3c98c44aac&selectedJob=228214988

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228214988&repo=autoland&lineNumber=275

Backout: https://hg.mozilla.org/integration/autoland/rev/8df956c34c94173d02cd69594a2a24b76818c23a

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b745576a1639
Add a standard mechanism for requesting data from the other process. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/7897f18e59f5
about:newinstall should get its configuration via RemotePageManager rather than query params. r=Gijs

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b745576a1639
https://hg.mozilla.org/mozilla-central/rev/7897f18e59f5