newPageInstall should get its FxA endpoint from FxAccounts.config.

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(3 attachments)

We decided against blocking landing for this, but we really should be using FxAccounts.config to get the Accounts endpoint for the login form. This will probably involve switching to using RemotePageManager to request the endpoint when the page loads.

Assignee

Comment 2

4 months ago

As we add more specific methods to RemotePageManager some of them will have to
call the main process to get the results. This adds a standard mechanism for
doing so. Calling sendRequest will return a promise that is resolved or rejected
when the main process responds.

Assignee

Comment 4

4 months ago

The patches here end up adding the service and context parameters to the metrics request (because FxAccounts.config adds them by default: https://searchfox.org/mozilla-central/source/services/fxaccounts/FxAccountsConfig.jsm#73), is that a problem?

Flags: needinfo?(stomlinson)

(In reply to Dave Townsend [:mossop] (he/him) from comment #4)

The patches here end up adding the service and context parameters to the metrics request (because FxAccounts.config adds them by default: https://searchfox.org/mozilla-central/source/services/fxaccounts/FxAccountsConfig.jsm#73), is that a problem?

I just tried from the network console in firefox:

Request URL:https://accounts.firefox.com/metrics-flow?entrypoint=new-install-page&utm_source=new-install-page-release&utm_campaign=dedicated-profiles&form_type=email&service=sync&context=fx_desktop_v3
Request method:GET
Remote address:<xxxx>
Status code:
200
Version:HTTP/1.1

All good.

Flags: needinfo?(stomlinson)

Comment 6

4 months ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcc0c69e319e
Convert RemotePageManager to ES6 classes. r=Gijs
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Comment 8

4 months ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a091f6b58aba
Add a standard mechanism for requesting data from the other process. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/5b2aeaf2da17
about:newinstall should get its configuration via RemotePageManager rather than query params. r=Gijs

Comment 10

4 months ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b745576a1639
Add a standard mechanism for requesting data from the other process. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/7897f18e59f5
about:newinstall should get its configuration via RemotePageManager rather than query params. r=Gijs
Assignee

Updated

4 months ago
Flags: needinfo?(dtownsend)
You need to log in before you can comment on or make changes to this bug.