1522290 - Remove Linux-only toolbarbutton-dropdown binding

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P3)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/rev/39265dd58298c40bed029617ad408bf806cce761/browser/themes/linux/places/organizer.css#64

https://searchfox.org/mozilla-central/source/browser/themes/linux/places/organizer.xml

It looks like this just adds a dropdown icon and changes the padding a bit. That could all be done in CSS or dropped.

Comment 1

[Tim Nguyen :ntim]

Dão, Marco, Do you know why the library window is using a menubar + menu as opposed to toolbarbutton[type=menu] which would provide the correct markup and styling on Linux and Windows ?

It seems to me that using toolbarbutton[type=menu] everywhere like we already do on macOS would allow getting rid of the Linux binding.

https://searchfox.org/mozilla-central/source/browser/components/places/content/places.xul#170-176

What do you think ?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen :ntim from comment #1)

Dão, Marco, Do you know why the library window is using a menubar + menu as opposed to toolbarbutton[type=menu] which would provide the correct markup and styling on Linux and Windows ?

To make it accessible like a menu bar, e.g. use Alt+O to open the Organize menu.

Comment 3

[Marco Bonardo [:mak]]

There's some history in bug 400703

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1522290 - Remove Linux-only toolbarbutton-dropdown binding. r=dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e034cf8eb6f2
Remove Linux-only toolbarbutton-dropdown binding. r=dao

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e034cf8eb6f2