Remove Linux-only toolbarbutton-dropdown binding

RESOLVED FIXED in Firefox 67

Status

()

P3
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

(Blocks: 2 bugs)

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Blocks: 1397874
(Assignee)

Comment 1

2 months ago

Dão, Marco, Do you know why the library window is using a menubar + menu as opposed to toolbarbutton[type=menu] which would provide the correct markup and styling on Linux and Windows ?

It seems to me that using toolbarbutton[type=menu] everywhere like we already do on macOS would allow getting rid of the Linux binding.

https://searchfox.org/mozilla-central/source/browser/components/places/content/places.xul#170-176

What do you think ?

Flags: needinfo?(mak77)
Flags: needinfo?(dao+bmo)

(In reply to Tim Nguyen :ntim from comment #1)

Dão, Marco, Do you know why the library window is using a menubar + menu as opposed to toolbarbutton[type=menu] which would provide the correct markup and styling on Linux and Windows ?

To make it accessible like a menu bar, e.g. use Alt+O to open the Organize menu.

Flags: needinfo?(dao+bmo)
Flags: needinfo?(mak77)

There's some history in bug 400703

Priority: -- → P3
Assignee: nobody → ntim.bugs

Comment 5

a month ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e034cf8eb6f2
Remove Linux-only toolbarbutton-dropdown binding. r=dao

Comment 6

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.