152231 - InternetConfigService should be part of uriloader rather than appshell

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Steve Dagley]

Logging new bug for relocation of the nsInternetConfigService...

The nsInternetConfigService, which provides services such as MIME type mapping
and external protocol handling, currently is part of appshell.  This is the
wrong location for such a service and basically the only reason Mac embedding
clients depend on the appshell component.  To break this dependency, and provide
a more appropriate home for the service it should be moved to uriloader.  This
was agreed to by mscott and alecf.

The first step in the relocation is CVS moving the files associated with the
nsInternetConfigService from the appshell directories to uriloader. 
Specifically these files:

/mozilla/xpfe/appshell/public/nsIInternetConfigService.idl
/mozilla/xpfe/appshell/src/nsInternetConfig.cpp
/mozilla/xpfe/appshell/src/nsInternetConfig.h
/mozilla/xpfe/appshell/src/nsInternetConfigService.cpp
/mozilla/xpfe/appshell/src/nsInternetConfigService.h
/mozilla/xpfe/appshell/src/nsMacMIMEDataSource.cpp
/mozilla/xpfe/appshell/src/nsMacMIMEDataSource.h

All 7 of these files should be moved to:

/mozilla/uriloader/exthandler/mac/

Once the files are CVS moved I can check in the changes to build with the
relocated files (patch forthcoming) and remove the now obsolete originals in
/mozilla/xpfe/appshell/

Comment 1

[Steve Dagley]

Attachment: Patch to build nsInternetConfigService in uriloader instead of appshell

Comment 2

[Steve Dagley]

Comment on attachment 87881 [details] [diff] [review]
Patch to build nsInternetConfigService in uriloader instead of appshell

Oops, had some experimental cruft in tree, lemme try that again

Comment 3

[Steve Dagley]

Attachment: right version of patch to build nsInternetConfigService in uriloader

Comment 4

[Steve Dagley]

ccarlen was helping me get this working in the Chimera branch and discovered the
VPATH part in makefiles apparently doesn't work with IDL files.  This means
nsIInternetConfigService.idl can't be in /mozilla/uriloader/exthandler/mac/ so
here's the revised list of files to move and where they need to be moved to:

/mozilla/xpfe/appshell/public/nsIInternetConfigService.idl
--> /mozilla/uriloader/exthandler/

/mozilla/xpfe/appshell/src/nsInternetConfig.cpp
/mozilla/xpfe/appshell/src/nsInternetConfig.h
/mozilla/xpfe/appshell/src/nsInternetConfigService.cpp
/mozilla/xpfe/appshell/src/nsInternetConfigService.h
/mozilla/xpfe/appshell/src/nsMacMIMEDataSource.cpp
/mozilla/xpfe/appshell/src/nsMacMIMEDataSource.h
--> /mozilla/uriloader/exthandler/mac/

Comment 5

[Daniel (Leaf) Nunes]

files copied, you may update your build system stuff and cvs remove the old file
locations.

Comment 6

[Conrad Carlen (not reading bugmail)]

Attachment: Patch to uriloader to build IC [for Chimera branch]

Makefile changes to get it to build with the Mach-0 build and compile with gcc.
There were some const violations in nsInternetConfigService.cpp that CW would
allow :-/

Comment 7

[Steve Dagley]

This is still waiting on the Chimera changes to be brought over to the trunk
which I _think_ we're planning on doing for Mozilla 1.2

Comment 8

[Conrad Carlen (not reading bugmail)]

Comment on attachment 87886 [details] [diff] [review]
right version of patch to build nsInternetConfigService in uriloader

r=ccarlen

Comment 9

[Steve Dagley]

Attachment: patch for CFM updated to current trunk

Moves nsInternetConfigService into uriloader for CFM build.  First step to
getting it there for mach-o build

Comment 10

[Scott Collins]

Comment on attachment 100074 [details] [diff] [review]
patch for CFM updated to current trunk

sr=scc

Comment 11

[Steve Dagley]

Comment on attachment 100074 [details] [diff] [review]
patch for CFM updated to current trunk

bringing forward ccarlen's r=

Comment 12

[Steve Dagley]

Attachment: conrad's patch from Chimera branch updated for trunk

Updated version of conrad's patch to mach-o build for building ICService in
uriloader

Comment 13

[Steve Dagley]

Comment on attachment 100074 [details] [diff] [review]
patch for CFM updated to current trunk

This patch is now landed on the trunk.	Leaving bug open until the mach-o
changes land

Comment 14

[Steve Dagley]

Attachment: ccarlen's patch updated for trunk take 2

fixed conflict with darin's prefetch landing

Comment 15

[Steve Dagley]

Attachment: ccarlen's patch updated _and_ buildable

Patch updated to actually build on trunk

Comment 16

[Steve Dagley]

Comment on attachment 101203 [details] [diff] [review]
ccarlen's patch updated _and_ buildable

r=sdagley (I'm claiming the r= since ccarlen made it work on the Chimera
branch, I just abused it until it built on the trunk)

Comment 17

[Darin Fisher]

Comment on attachment 101203 [details] [diff] [review]
ccarlen's patch updated _and_ buildable

sr=darin

nit: how about unifying the tabs in widget/src/mac/Makefile.in while you're
touching it.

Comment 18

[Steve Dagley]

landed

Comment 19

[Michael Dunn]

To ashish for bug verification

Comment 20

[Ashish Bhatt]

marking as verified