1522354 - configure thinks Windows hosts are 32-bit when they are in fact 64-bit

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Denis Palmeiro [:denispal]]

Attachment: config.log.txt

When cross-compiling for arm64 on an x64 Windows 10 machine, the configure step believes that the host is a 32 bit system. Attached is the config.log.

Comment 1

[Mike Hommey [:glandium] OoO until Dec 30]

See bug 1510788 comment 1.

Comment 2

[Mike Hommey [:glandium] OoO until Dec 30]

Attachment: Bug 1522354 - Avoid running config.sub in cases we don't really need to.

• We assume the output from config.guess is sufficiently normalized for
  our needs.
• If we partially derive the target from the host (with only the cpu
  given for --target), we assume the derived value doesn't need
  canonicalization.

Comment 3

[Mike Hommey [:glandium] OoO until Dec 30]

Attachment: Bug 1522354 - Derive configure host from the environment when possible on Windows.

config.guess doesn't actually figure out the real host system on
Windows. All it does is end up finding the CPU for which the msys used
for the shell is built for. Which has the unfortunate effect that if you
build on a 64-bits host, configure pretends the host is 32-bits.

So instead, rely on some environment variables that should be set
mostly everywhere, and derive the corresponding triplet.

This has two effects:

• configure now knows that the host is 64-bits when it is.
• consequently, configure will build a 64-bits Firefox on 64-bits hosts
  by default (since by default, the target is derived from the host), and
  that's actually a desired side effect.

Depends on D17620

Comment 4

[Mike Hommey [:glandium] OoO until Dec 30]

Attachment: Bug 1522354 - Remove --host=x86_64-pc-mingw32 from mozconfigs now that it is detected correctly.

Depends on D17621

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/008b78c1e2b2
Avoid running config.sub in cases we don't really need to. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/ad5f8b0171be
Derive configure host from the environment when possible on Windows. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/268134627d91
Remove --host=x86_64-pc-mingw32 from mozconfigs now that it is detected correctly. r=nalexander

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/008b78c1e2b2
https://hg.mozilla.org/mozilla-central/rev/ad5f8b0171be
https://hg.mozilla.org/mozilla-central/rev/268134627d91

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8ec38641243a
Port bug 1522354 - Remove --host=x86_64-pc-mingw32 from C-C's mozconfigs. rs=bustage-fix DONTBUILD