1522391 - prevent arc from waiting on user input, which manifests as a moz-phab hang

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement, P1)

Description

[:glob ✱]

under some circumstances moz-phab appears to hang (eg bug 1521980), with the cause being arc is waiting for user input.

looking over arc's code it appears that if we connect the subprocess's STDIN to a pipe, arc will throw an exception instead of waiting for a response. look for phutil_console_require_tty in libphutil's src/console/format.php.

Comment 1

[Piotr Zalewa [:zalun]]

Attachment: Bug 1522391 - Prevent arc from waiting on user input, which manifests as a moz-phab hang r=glob

Connecting the STDIN to the PIPE will make arc throw an exception on reading
user input:

read user input, but stdin is being piped from some other source (not a TTY)```