1522408 - "WebDriver:MinimizeWindow" and "WebDriver:FullscreenWindow" don't initially restore normal window state

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I have seen this yesterday while working on bug 1521028. Both the commands do not restore the normal window state before entering the requested state. It means that it causes side-effects, and test failures for tests I'm going to add on bug 1521028.

As written in the WebDriver specification the window has to be restored or to unhide, which implies to me that it also has to be changed from a maximized to a normal state:

https://w3c.github.io/webdriver/#dfn-restore-the-window

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I want to land this separate to have it shipped a bit faster given that the work on bug 1521028 would still take at least one more day.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8df7e11f47b335fffa2b6f890d9479607fe02bbe

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1522408 - [marionette] Restore maximized window first before entering fullscreen or minimizing the window. r?ato

The window should always be restored first to the normal window state,
before a special state like fullscreen or minimized can be entered.

Right now this isn't done when going from a maximized window into
fullscreen mode, or when minimizing the window.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't understand what's happening here in the try build for MacOS opt builds, and the wpt1 and wpt2 test jobs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8df7e11f47b335fffa2b6f890d9479607fe02bbe

Why are the web-audio tests failing on that platform and build combination only? When I run this all locally I don't see any failures for web-audio.

I talk to Nils and he suggested to ask Paul about it. Paul, when you have a bit of time (once you are back) could you please have a look? Thanks!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, I can actually replicate this problem when using the Firefox binary from the try build as created by TaskCluster:
https://queue.taskcluster.net/v1/task/TL4UGw1vTWusgnOVzm3OQA/runs/0/artifacts/public/build/target.dmg

Maybe there is something busted with the artifact build? To prove that submitted another try build with a full build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=441ab2717ff9423a6a09c5972612239d9bdae101

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, that full try build was successful. So it's most likely that there was a problem with the generated artifact build, or the commit is was based off, and a patch for those failures landed afterward.

This is safe to review and land.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4740a865552
[marionette] Restore maximized window first before entering fullscreen or minimizing the window. r=ato

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d4740a865552