1522424 - Sync Allow Firefox to send backlogged crash reports on your behalf option

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Artem Polivanchuk]

Currently, the option "Allow Firefox to send backlogged crash reports on your behalf" is not synced.

It has to be changed on each firefox instance.
Once the user decided to send the backlogged crash reports, this option should be distributed via Sync to all connected Firefox instances.

Comment 1

[Lina Butler [:lina]]

Here's how we can find the pref name for this option:

First, we type the string into Searchfox (https://searchfox.org), which is a code search tool for Firefox. Here are the results: https://searchfox.org/mozilla-central/search?q=backlogged+crash+reports&case=false&regexp=false&path=

In this case, we're looking for a .dtd, .properties, or .ftl file, with the string and string ID. We use these files for localization, so that, for example, about:preferences can refer to the string ID for that option, without including the string directly in the HTML or XUL.

For this bug, we have a result in preferences.ftl, which is a Fluent file containing the pref strings. Fluent is our newest l10n system, and documented here, if you're interested: https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/preferences/preferences.ftl

So we can see that the string ID for that option is "collection-backlogged-crash-reports" (https://searchfox.org/mozilla-central/rev/465dbfe030dfec7756b9b523029e90d48dd5ecce/browser/locales/en-US/browser/preferences/preferences.ftl#955-957). Let's search for that: https://searchfox.org/mozilla-central/search?q=collection-backlogged-crash-reports&case=false&regexp=false&path=

This time, we get a result in privacy.xul, which is the Privacy screen in about:preferences. Clicking that result, we see the checkbox for that option, with a preference="browser.crashReports.unsubmittedCheck.autoSubmit2" attribute (https://searchfox.org/mozilla-central/rev/465dbfe030dfec7756b9b523029e90d48dd5ecce/browser/components/preferences/in-content/privacy.xul#690-694).

So now we know that the about:config pref name for "Allow Firefox to send backlogged crash reports on your behalf" is browser.crashReports.unsubmittedCheck.autoSubmit2.

And all we need to do is add another default pref for Sync: services.sync.prefs.sync.browser.crashReports.unsubmittedCheck.autoSubmit2.

Comment 2

[Artem Polivanchuk]

Attachment: Bug 1522424 - Sync Allow Firefox to send backlogged crash reports on your behalf option

Comment 3

[Artem Polivanchuk]

Lina, Thank you for the detailed description, it's really helpful.
I see that the file in this patch doesn't have the changes from the previously accepted differentials.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1efd079a7f7a
Sync Allow Firefox to send backlogged crash reports on your behalf option r=lina

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1efd079a7f7a