Closed Bug 1522446 Opened 5 years ago Closed 5 years ago

GeckoView: Pull to refresh

Categories

(GeckoView :: General, enhancement, P1)

Unspecified
Android
enhancement

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: sebastian, Unassigned)

References

Details

(Whiteboard: [geckoview:fenix:p1])

Fenix: https://github.com/mozilla-mobile/fenix/issues/103
Android Components: https://github.com/mozilla-mobile/android-components/issues/1824

There's an desire to support the pull-to-refresh gesture for quick page reloads.

A) Is this something the Gecko(View) team would implement internally? It may be easier for Gecko(View) to synchronize the gesture with the page scrolling.

B) Is this something we should implement at the Android level via nested scrolling? This may need some hooks for us to know more about the scrolling state, see bug 1507569

Eugen, do you think pull-to-refresh (gesture handling and page reloading) is best handled in GV or the app (or an Android-Component)? Are your instructions for implementing pull-to-refresh in bug 1162150 comment 36 still accurate?

Flags: needinfo?(esawin)
See Also: → 1162150
Whiteboard: [geckoview:fenix:p2]
Priority: -- → P2

[geckoview:fenix:p1] because https://github.com/mozilla-mobile/android-components/issues/1819 says pull-to-refresh is a must-have for Fenix MVP.

OS: All → Android
Priority: P2 → P1
Whiteboard: [geckoview:fenix:p2] → [geckoview:fenix:p1]

(In reply to Chris Peterson [:cpeterson] from comment #1)

Eugen, do you think pull-to-refresh (gesture handling and page reloading) is best handled in GV or the app (or an Android-Component)? Are your instructions for implementing pull-to-refresh in bug 1162150 comment 36 still accurate?

We provide the ScrollDelegate to broadcast updates on the horizontal and vertical content scroll positions.
I was able to implement pull-to-refresh in GVE using this API and SwipeRefreshLayout, which was the recommended way of doing it at this time.

I don't know whether that's a feasible way to implement it in a more complex app, and would like to hear some input on that from the Android devs. We might need to extend the current API if that's not the case.

Generally speaking, I think this should be an app-level (or a-c) implementation based on GV's generic APIs.

Flags: needinfo?(esawin)

Thank you! That sounds good and should be enough to get us started.

(In reply to Eugen Sawin [:esawin] from comment #4)

Generally speaking, I think this should be an app-level (or a-c) implementation based on GV's generic APIs.

In that case, I will close this GV bug.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Depends on: 1557411
You need to log in before you can comment on or make changes to this bug.