Open Bug 1522464 Opened 6 years ago Updated 2 years ago

Enhance the OriginParser for obsolete origins

Categories

(Core :: Storage: Quota Manager, enhancement, P2)

enhancement

Tracking

()

People

(Reporter: tt, Unassigned)

References

(Depends on 1 open bug)

Details

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=1423917#c73
https://bugzilla.mozilla.org/show_bug.cgi?id=1423917#c88

Before bug 1423917, obsolete origins were supposed to generate Spec string after parsing. P3 there make this be not guaranteed anymore. Although, the current code won't touch spec if it's an obsolete origin
The possible solutions are:

  • Parse obsolete origins till the end so that we would get the spec for the given directory.
  • Have a wrapper to protect the spec and have an assertion to avoid from accessing if the caller gets these kinds of information when it's an obsolete origin.
  • Use mfbt/Variant.h or similar stuff to ensure spec is not available when it's an obsolete origin.

Note that: it's actually only blocked by the P3 in the bug 1423917

Assignee: ttung → nobody
Status: ASSIGNED → NEW

Maybe we can get rid of OriginParser in the end.

Depends on: 1593365
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.