1522479 - XCUITests: New tests for Cell Labels

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

In order to save a tab when going to Settings a label will be added for each cell. Let's try to add tests to this new feature when ready

Comment 1

[Isabel Rios[:isabel_rios]]

Please see bug 1524516 for clarification. Although the feature has landed on master bug Bug 1522933, there are some questions to be answered to know how to implement the tests

Comment 3

[Kate Glazko]

Attachment: GitHub Pull Request

Comment 4

[Isabel Rios[:isabel_rios]]

Comment on attachment 9045089 [details] [review]
GitHub Pull Request

Hey, thanks for the PR! I have commented on Github. There is some work needed around the back actions. There is a way to handle that from the ScreenGraph instead of doing it in the tests. There are also some duplicates lines which do the same. And lastly, please be sure the tests are enabled only in the desired schema and not in all of them.

Apart from that the tests look good :) 
Thanks!

Comment 5

[Kate Glazko]

Comment on attachment 9045089 [details] [review]
GitHub Pull Request

Made suggested changes and removed from Smoketest schema (oops on that one)

Comment 6

[Isabel Rios[:isabel_rios]]

Comment on attachment 9045089 [details] [review]
GitHub Pull Request

LGTM! Thanks for fixing all the comments :) 
Once BB shows these tests passed, it can be merged

Comment 7

[Isabel Rios[:isabel_rios]]

Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/50bfc36643a8e3c0ff0be80039a3e2e8cbbfde98