Closed Bug 1522507 Opened 10 months ago Closed 10 months ago

Update VS package for (at least) the aarch64 builds

Categories

(Firefox Build System :: Toolchains, defect)

defect
Not set

Tracking

(firefox66 fixed, firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox66 --- fixed
firefox67 --- fixed

People

(Reporter: dmajor, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Even though we're switching to clang-cl, we still use a VS package for its redistributables, among other things.

Currently the aarch64 builds use VS 15.9.0 preview 5. It's probably not a good idea to let a preview-based product ride the trains to release. Let's update now that 15.9 is released.

A bonus is that release versions of 15.9 appear to have proper (not onecore) versions of the arm64 redists.

Other Windows builds use 15.8.4. I'm thinking we might as well update those too for consistency across products, though it's not strictly necessary.

(In reply to David Major [:dmajor] from comment #0)

Other Windows builds use 15.8.4. I'm thinking we might as well update those
too for consistency across products, though it's not strictly necessary.

I'd be happy to take this, but I'd like an answer to this first. IIRC, glandium was the one who wasn't a fan of updating the MSVC version for non-aarch64?

Flags: needinfo?(mh+mozilla)

Yeah, not a fan, especially at this point of the cycle.

Flags: needinfo?(mh+mozilla)

Green on Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa5b8d3ca391f87ce34dc8e9bce7db2322832884&group_state=expanded

Of note, this drops the OneCore stuff from the package, cutting about 100MB off the zip size. David, can you please verify that the Try builds run successfully on a real device?

Assignee: nobody → ryanvm
Flags: needinfo?(dmajor)

Launches fine for me.

Flags: needinfo?(dmajor)
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fb218c2d332
Update Windows ARM64 builds to Visual Studio 2017 15.9.6. r=froydnj
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Comment on attachment 9039299 [details]
Bug 1522507 - Update Windows ARM64 builds to Visual Studio 2017 15.9.6. r=froydnj

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1503366

User impact if declined

Windows ARM64 builds shipping off the Beta branch will be using a prerelease compiler instead of a final build.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Doesn't affect any builds we distribute.

String changes made/needed

None

Attachment #9039299 - Flags: approval-mozilla-beta?

Comment on attachment 9039299 [details]
Bug 1522507 - Update Windows ARM64 builds to Visual Studio 2017 15.9.6. r=froydnj

Update to build with release version of VS2017.
OK to uplift!

Attachment #9039299 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.