1522507 - Update VS package for (at least) the aarch64 builds

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[(Away)]

Even though we're switching to clang-cl, we still use a VS package for its redistributables, among other things.

Currently the aarch64 builds use VS 15.9.0 preview 5. It's probably not a good idea to let a preview-based product ride the trains to release. Let's update now that 15.9 is released.

A bonus is that release versions of 15.9 appear to have proper (not onecore) versions of the arm64 redists.

Other Windows builds use 15.8.4. I'm thinking we might as well update those too for consistency across products, though it's not strictly necessary.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

(In reply to David Major [:dmajor] from comment #0)

Other Windows builds use 15.8.4. I'm thinking we might as well update those
too for consistency across products, though it's not strictly necessary.

I'd be happy to take this, but I'd like an answer to this first. IIRC, glandium was the one who wasn't a fan of updating the MSVC version for non-aarch64?

Comment 2

[Mike Hommey [:glandium]]

Yeah, not a fan, especially at this point of the cycle.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1522507 - Update Windows ARM64 builds to Visual Studio 2017 15.9.6. r=froydnj

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Green on Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa5b8d3ca391f87ce34dc8e9bce7db2322832884&group_state=expanded

Of note, this drops the OneCore stuff from the package, cutting about 100MB off the zip size. David, can you please verify that the Try builds run successfully on a real device?

Comment 5

[(Away)]

Launches fine for me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fb218c2d332
Update Windows ARM64 builds to Visual Studio 2017 15.9.6. r=froydnj

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1fb218c2d332

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9039299 [details]
Bug 1522507 - Update Windows ARM64 builds to Visual Studio 2017 15.9.6. r=froydnj

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1503366

User impact if declined

Windows ARM64 builds shipping off the Beta branch will be using a prerelease compiler instead of a final build.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Doesn't affect any builds we distribute.

String changes made/needed

None

Comment 9

[Liz Henry (:lizzard)]

Comment on attachment 9039299 [details]
Bug 1522507 - Update Windows ARM64 builds to Visual Studio 2017 15.9.6. r=froydnj

Update to build with release version of VS2017.
OK to uplift!

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/c92744fdd50e