Status

()

enhancement
P2
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: Nika, Assigned: Nika)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Fission Milestone:M2, firefox67 fixed)

Details

Attachments

(6 attachments)

Since bug 1500257, we no longer have a need for the PContentBridge logic. This logic currently doesn't run (due to failing assertions), and is from the old B2G days. We should rip this actor out entirely to simplify the situation around PBrowser and nsIContentParent.

Priority: -- → P3

This actor won't be being used anymore, and acts only as a maintenance burden
for people working on this code (which we're doing pretty often these days!).

This patch tries to move them to ContentParent instead.

ProcessPriorityManagerImpl::ObserveContentParentCreated could not be moved
due to using do_QueryInterface to cast from a nsISupports down to the
ContentParent object. This could be fixed to remove the interfaces entirely,
but I left that for a follow-up.

Depends on D20549

Like Part 2, however for nsIContentChild.

Depends on D20550

These casts are now unnecessary after Part 2, due to all consumers directly
using ContentParent.

Depends on D20551

Assignee: nobody → nika

This devirutalizes a bunch of methods, and moves the entire implementation into
Content{Parent,Child} proper. The only purpose left for these types is as a
collection of interfaces and an IID for casting. They should likely be removed
entirely in a follow-up.

Depends on D20552

Fission Milestone: --- → M2
Priority: P3 → P2
Blocks: 1529684

Looks like this is deleting some JS Plugin stuff, so qDot might want to be aware of it.

Component: DOM → DOM: Content Processes

Thanks for the heads up, I checked through the patch and have notes to remove IsForJSPlugin now in some of my cleanup patches (whenever I get around to them).

Comment 9

4 months ago
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3c5a2c16411
Part 1: Remove PContentBridge, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5c7aafa32a0a
Part 2: Remove consumers of nsIContentParent, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/eda40fca0758
Part 3: Remove consumers of nsIContentChild, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/ecfd27e7d150
Part 4: Remove {As,Is}ContentParent, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0a288a3d85cd
Part 5: Reduce nsIContent{Parent,Child} to thin IIDs, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3c8320baa230
Part 6: Completely remove nsIContent{Parent,Child}, r=mccr8

Fixed & re-landing. Thanks.

Flags: needinfo?(nika)

Comment 12

4 months ago
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86948cd89919
Part 1: Remove PContentBridge, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/1e8608ac029b
Part 2: Remove consumers of nsIContentParent, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9cdcafda796e
Part 3: Remove consumers of nsIContentChild, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e1a05b9c3e37
Part 4: Remove {As,Is}ContentParent, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5174b698bd09
Part 5: Reduce nsIContent{Parent,Child} to thin IIDs, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/70bcec52a773
Part 6: Completely remove nsIContent{Parent,Child}, r=mccr8
You need to log in before you can comment on or make changes to this bug.