1522579 - Rip out PContentBridge

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

Since bug 1500257, we no longer have a need for the PContentBridge logic. This logic currently doesn't run (due to failing assertions), and is from the old B2G days. We should rip this actor out entirely to simplify the situation around PBrowser and nsIContentParent.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522579 - Part 1: Remove PContentBridge,

This actor won't be being used anymore, and acts only as a maintenance burden
for people working on this code (which we're doing pretty often these days!).

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522579 - Part 2: Remove consumers of nsIContentParent,

This patch tries to move them to ContentParent instead.

ProcessPriorityManagerImpl::ObserveContentParentCreated could not be moved
due to using do_QueryInterface to cast from a nsISupports down to the
ContentParent object. This could be fixed to remove the interfaces entirely,
but I left that for a follow-up.

Depends on D20549

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522579 - Part 3: Remove consumers of nsIContentChild,

Like Part 2, however for nsIContentChild.

Depends on D20550

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522579 - Part 4: Remove {As,Is}ContentParent,

These casts are now unnecessary after Part 2, due to all consumers directly
using ContentParent.

Depends on D20551

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522579 - Part 5: Reduce nsIContent{Parent,Child} to thin IIDs,

This devirutalizes a bunch of methods, and moves the entire implementation into
Content{Parent,Child} proper. The only purpose left for these types is as a
collection of interfaces and an IID for casting. They should likely be removed
entirely in a follow-up.

Depends on D20552

Comment 6

[Andrew McCreight [:mccr8]]

Looks like this is deleting some JS Plugin stuff, so qDot might want to be aware of it.

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Thanks for the heads up, I checked through the patch and have notes to remove IsForJSPlugin now in some of my cleanup patches (whenever I get around to them).

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522579 - Part 6: Completely remove nsIContent{Parent,Child},

Depends on D20553

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c5a2c16411
Part 1: Remove PContentBridge, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5c7aafa32a0a
Part 2: Remove consumers of nsIContentParent, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/eda40fca0758
Part 3: Remove consumers of nsIContentChild, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/ecfd27e7d150
Part 4: Remove {As,Is}ContentParent, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0a288a3d85cd
Part 5: Reduce nsIContent{Parent,Child} to thin IIDs, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3c8320baa230
Part 6: Completely remove nsIContent{Parent,Child}, r=mccr8

Comment 10

[Andreea Pavel [:apavel]]

Backed out for build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=3c8320baa230205e3a8646051f13ce2c51d45a74&selectedJob=230327063

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230327063&repo=autoland&lineNumber=36408

Backout: https://hg.mozilla.org/integration/autoland/rev/2777f00531253613cabfa34b6a1e5d5a21ea4478

Comment 11

[Nika Layzell [:nika] (ni? for response)]

Fixed & re-landing. Thanks.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86948cd89919
Part 1: Remove PContentBridge, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/1e8608ac029b
Part 2: Remove consumers of nsIContentParent, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9cdcafda796e
Part 3: Remove consumers of nsIContentChild, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e1a05b9c3e37
Part 4: Remove {As,Is}ContentParent, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5174b698bd09
Part 5: Reduce nsIContent{Parent,Child} to thin IIDs, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/70bcec52a773
Part 6: Completely remove nsIContent{Parent,Child}, r=mccr8

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/86948cd89919
https://hg.mozilla.org/mozilla-central/rev/1e8608ac029b
https://hg.mozilla.org/mozilla-central/rev/9cdcafda796e
https://hg.mozilla.org/mozilla-central/rev/e1a05b9c3e37
https://hg.mozilla.org/mozilla-central/rev/5174b698bd09
https://hg.mozilla.org/mozilla-central/rev/70bcec52a773