Open Bug 1522628 Opened 6 years ago Updated 2 years ago

Add an explicit isEnabled flag that is returned from parseDeclarations

Categories

(DevTools :: Inspector: Rules, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: gl, Unassigned)

References

(Blocks 1 open bug)

Details

Originally commented in https://bugzilla.mozilla.org/show_bug.cgi?id=1521678#c6.

When we add a new property value, we call parseDeclaration() to get the declarations to add. We would then have to do something like:

const isCommented = Boolean(declaration.commentOffsets);
const isEnabled = !isCommented;

To figure out if the property to be added is enabled or not. We currently do this in ElementStyle#modifyDeclarationValue. We should have the parsed declarations provide an isEnabled flag so we don't have to parse this out manually outside the parseDeclaration function.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.