1522637 - Fix various issues with httpResponseProcessSelection pref

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

In bug 1467223, the pref "browser.tabs.remote.useHTTPResponseProcessSelection" was added. When enabled this allows for toplevel loads to change their process mid-http load in basic cases.

This bug tracks enabling that pref by default.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 1: Disable in tests for allowLinkedWebInFileUriProcess,

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 2: Include BrowsingContextID in LoadInfo for subdocument loads,

Depends on D18602

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 3: Send history index when resuming redirected loads,

Depends on D18603

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 4: Support browsers in globals without gMultiProcessBrowser,

Depends on D18604

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 5: Add tests for history navigations between http and file URIs with new pref,

Depends on D18605

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 6: Enable httpResponseProcessSelection by default,

Depends on D18606

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=428d032bc24c610c0434d3de5fa724abe66548ca

Here's hoping I caught all of the issues :-)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f82ba91f5ea2
Part 1: Disable in tests for allowLinkedWebInFileUriProcess, r=bobowen
https://hg.mozilla.org/integration/autoland/rev/5f49cd87b1bd
Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
https://hg.mozilla.org/integration/autoland/rev/5a8067fd848c
Part 3: Send history index when resuming redirected loads, r=qdot
https://hg.mozilla.org/integration/autoland/rev/f1191be4243a
Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
https://hg.mozilla.org/integration/autoland/rev/9e9fd362dd8f
Part 5: Add tests for history navigations between http and file URIs with new pref, r=qdot
https://hg.mozilla.org/integration/autoland/rev/18a809d53298
Part 6: Enable httpResponseProcessSelection by default, r=qdot

Comment 11

[Stefan Hindli [:stefan_hindli]]

Backed out 6 changesets (Bug 1522637) for en-US failures in testing/firefox-ui/tests/functional/safebrowsing/test_notification.py TestSafeBrowsingNotificationBar.test_notification_bar CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=010180a16818d72bcbb68940509386b3318fd93b&selectedJob=227314522

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=227314522&repo=autoland&lineNumber=7199

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3433b7761096
Backed out 6 changesets for en-US failures in testing/firefox-ui/tests/functional/safebrowsing/test_notification.py TestSafeBrowsingNotificationBar.test_notification_bar CLOSED TREE

Comment 13

[Narcis Beleuzu [:NarcisB]]

There were also bc failures.
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=227313195&repo=autoland&lineNumber=5704

Comment 14

[Cristian Brindusan [:cbrindusan]]

Ading another bc log for browser_aboutnewtab_process_selection.js failures:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=227333243&repo=autoland&lineNumber=3808

Comment 15

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 6: Perform process switches separtely from on-examine-response,

Issues were occuring where a process swap would be decided upon during
on-examine-response, but before the swap could be handled by the
channel, the channel was redirected.

This new code takes the mildly hacky approach of simply using a separate
observer notification which is fired at the correct time. A better
solution may be to use a dedicated service for responding to these
events, however that was not implemented for this initial patch.

Depends on D18607

Comment 16

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 7: Perform the preloaded document swap before checking for HTTP loads,

For HTTP loads from the preloaded document, no process swap was occuring
if the preloaded document was loaded in a 'web' process. This caused
test failures, and has potentially undesireable behaviour.

This patch just moves the check for preloaded document swaps to before
the check for http parent process interception, forcing a swap like
normal.

Depends on D19691

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5988b8e7d17c
Part 1: Disable in tests for allowLinkedWebInFileUriProcess, r=bobowen
https://hg.mozilla.org/integration/autoland/rev/5eeda2ba8e79
Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
https://hg.mozilla.org/integration/autoland/rev/6b4d010964ec
Part 3: Send history index when resuming redirected loads, r=qdot
https://hg.mozilla.org/integration/autoland/rev/8f494271ec06
Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
https://hg.mozilla.org/integration/autoland/rev/6e0d4b6b1c93
Part 5: Add tests for history navigations between http and file URIs with new pref, r=qdot
https://hg.mozilla.org/integration/autoland/rev/41ca0b87537e
Part 6: Enable httpResponseProcessSelection by default, r=qdot
https://hg.mozilla.org/integration/autoland/rev/3d24e8e81c02
Part 7: Perform process switches separtely from on-examine-response, r=valentin
https://hg.mozilla.org/integration/autoland/rev/f7ab0e6e739b
Part 8: Perform the preloaded document swap before checking for HTTP loads, r=mconley

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 8 changesets (Bug 1522637) for browser_all_files_referenced.js failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64%2Fopt-mochitest-browser-chrome-e10s-7%2Cm-e10s%28bc7%29&fromchange=39bb681343d6f429ced7ea706649e48890d27c28&tochange=ff5227d3d1fd4f517bb5ceb696fcf8790c28fdaa&selectedJob=228430683

Backout link: https://hg.mozilla.org/integration/autoland/rev/ff5227d3d1fd4f517bb5ceb696fcf8790c28fdaa

ps: this also seems to have introduced a Tier 2 failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Copt%2Cfirefox%2Cfunctional%2Ctests%2C%28remote%29%2Cwith%2Ce10s%2Ctest-linux64%2Fopt-firefox-ui-functional-remote-e10s%2Cfxfn-r-e10s%28en-us%29&tochange=f7ab0e6e739bd54b66b8aaa6219c7dba78f37eb1&fromchange=39bb681343d6f429ced7ea706649e48890d27c28&selectedJob=228430680

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228430683&repo=autoland&lineNumber=2510

[task 2019-02-14T16:43:45.422Z] 16:43:45 INFO - TEST-START | browser/base/content/test/static/browser_all_files_referenced.js
[task 2019-02-14T16:43:56.647Z] 16:43:56 INFO - TEST-INFO | started process screentopng
[task 2019-02-14T16:43:57.154Z] 16:43:57 INFO - TEST-INFO | screentopng: exit 0
[task 2019-02-14T16:43:57.154Z] 16:43:57 INFO - Buffered messages logged at 16:43:45
[task 2019-02-14T16:43:57.155Z] 16:43:57 INFO - Entering test bound checkAllTheFiles
[task 2019-02-14T16:43:57.155Z] 16:43:57 INFO - Buffered messages logged at 16:43:56
[task 2019-02-14T16:43:57.155Z] 16:43:57 INFO - indirectly whitelisted file: chrome://marionette/content/test_dialog.dtd used from chrome://marionette/content/test_dialog.xul
...
[task 2019-02-14T16:43:57.227Z] 16:43:57 INFO - Buffered messages finished
[task 2019-02-14T16:43:57.228Z] 16:43:57 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected 0
[task 2019-02-14T16:43:57.230Z] 16:43:57 INFO - Stack trace:
[task 2019-02-14T16:43:57.231Z] 16:43:57 INFO - chrome://mochikit/content/browser-test.js:test_is:1315
[task 2019-02-14T16:43:57.235Z] 16:43:57 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:782
[task 2019-02-14T16:43:57.237Z] 16:43:57 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
[task 2019-02-14T16:43:57.238Z] 16:43:57 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1134
[task 2019-02-14T16:43:57.239Z] 16:43:57 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
[task 2019-02-14T16:43:57.240Z] 16:43:57 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-02-14T16:43:57.242Z] 16:43:57 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-02-14T16:43:57.243Z] 16:43:57 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: resource://gre/modules/FluentSyntax.jsm -
[task 2019-02-14T16:43:57.245Z] 16:43:57 INFO - Stack trace:
[task 2019-02-14T16:43:57.247Z] 16:43:57 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2019-02-14T16:43:57.249Z] 16:43:57 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:786
[task 2019-02-14T16:43:57.250Z] 16:43:57 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
[task 2019-02-14T16:43:57.251Z] 16:43:57 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1134
[task 2019-02-14T16:43:57.253Z] 16:43:57 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
[task 2019-02-14T16:43:57.254Z] 16:43:57 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-02-14T16:43:57.256Z] 16:43:57 INFO - ignored unused whitelist entry: resource://app/blocklist.xml

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

Sorry, wrong backout. Test has shifted between chunks.

Relanding in a few minutes.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f759e91eca8
Part 1: Disable in tests for allowLinkedWebInFileUriProcess, r=bobowen
https://hg.mozilla.org/integration/autoland/rev/e6ca9ad18d15
Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
https://hg.mozilla.org/integration/autoland/rev/7e38890c72fa
Part 3: Send history index when resuming redirected loads, r=qdot
https://hg.mozilla.org/integration/autoland/rev/67e838f49f4b
Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
https://hg.mozilla.org/integration/autoland/rev/d7eb272688be
Part 5: Add tests for history navigations between http and file URIs with new pref, r=qdot
https://hg.mozilla.org/integration/autoland/rev/4c7c512a262d
Part 6: Enable httpResponseProcessSelection by default, r=qdot
https://hg.mozilla.org/integration/autoland/rev/0886a317a108
Part 7: Perform process switches separtely from on-examine-response, r=valentin
https://hg.mozilla.org/integration/autoland/rev/540e5f318768
Part 8: Perform the preloaded document swap before checking for HTTP loads, r=mconley

Comment 21

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1522637 - Part 8: Allow 'element_stale' to work after process swap,

The element has never existed in the new process, so it gets a missing
error rather than a stale error in that case.

Depends on D19692

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4ca191d62a5
Part 9: Allow 'element_stale' to work after process swap, r=ato

Comment 23

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/0f759e91eca8
https://hg.mozilla.org/mozilla-central/rev/e6ca9ad18d15
https://hg.mozilla.org/mozilla-central/rev/7e38890c72fa
https://hg.mozilla.org/mozilla-central/rev/67e838f49f4b
https://hg.mozilla.org/mozilla-central/rev/d7eb272688be
https://hg.mozilla.org/mozilla-central/rev/4c7c512a262d
https://hg.mozilla.org/mozilla-central/rev/0886a317a108
https://hg.mozilla.org/mozilla-central/rev/540e5f318768
https://hg.mozilla.org/mozilla-central/rev/e4ca191d62a5

Comment 24

[Razvan Maries]

Backed out for causing bug 1528188.

Backout: https://hg.mozilla.org/mozilla-central/rev/99f1a95f032e1d90d5ab85c1d9a091df06fcf8d2

Comment 25

[Pascal Chevrel:pascalc (PTO until April 26)]

Thanks Razvan

Comment 26

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Fission Milestone got accidentally removed. Nika, can you put that back to M1, please?

Comment 27

[Nika Layzell [:nika] (ni? for response)]

Renaming the bug, as I'm going to move the actual enabling of the pref into a separate bug, so we can land this now.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/663ed0c62558
Part 1: Disable in tests for allowLinkedWebInFileUriProcess, r=bobowen
https://hg.mozilla.org/integration/autoland/rev/7eca000f53a6
Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
https://hg.mozilla.org/integration/autoland/rev/f3f386e5ae07
Part 3: Send history index when resuming redirected loads, r=qdot
https://hg.mozilla.org/integration/autoland/rev/ca6808f60f9b
Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
https://hg.mozilla.org/integration/autoland/rev/bfbc4f8775fc
Part 5: Add tests for history navigations between http and file URIs with new pref, r=qdot
https://hg.mozilla.org/integration/autoland/rev/28d4b904c004
Part 6: Perform process switches separtely from on-examine-response, r=valentin
https://hg.mozilla.org/integration/autoland/rev/f71650099143
Part 7: Perform the preloaded document swap before checking for HTTP loads, r=mconley
https://hg.mozilla.org/integration/autoland/rev/a92bdbd9b982
Part 8: Allow 'element_stale' to work after process swap, r=ato

Comment 29

[Phabricator Automation]

Comment on attachment 9041297 [details]
Bug 1522637 - Part 6: Enable httpResponseProcessSelection by default,

Revision D18607 was moved to bug 1528360. Setting attachment 9041297 [details] to obsolete.

Comment 30

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/663ed0c62558
https://hg.mozilla.org/mozilla-central/rev/7eca000f53a6
https://hg.mozilla.org/mozilla-central/rev/f3f386e5ae07
https://hg.mozilla.org/mozilla-central/rev/ca6808f60f9b
https://hg.mozilla.org/mozilla-central/rev/bfbc4f8775fc
https://hg.mozilla.org/mozilla-central/rev/28d4b904c004
https://hg.mozilla.org/mozilla-central/rev/f71650099143
https://hg.mozilla.org/mozilla-central/rev/a92bdbd9b982