1522878 - LeakCanary is not compatibled with isolatedProcess

Status: RESOLVED WORKSFORME

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

E/GeckoCrashHandler(22493): java.lang.SecurityException: Isolated process not allowed to call getRunningAppProcesses
E/GeckoCrashHandler(22493): at android.os.Parcel.readException(Parcel.java:1546)
E/GeckoCrashHandler(22493): at android.os.Parcel.readException(Parcel.java:1499)
E/GeckoCrashHandler(22493): at android.app.ActivityManagerProxy.getRunningAppProcesses(ActivityManagerNative.java:3121)
E/GeckoCrashHandler(22493): at android.app.ActivityManager.getRunningAppProcesses(ActivityManager.java:2219)
E/GeckoCrashHandler(22493): at com.squareup.leakcanary.internal.LeakCanaryInternals.isInServiceProcess(LeakCanaryInternals.java:117)
E/GeckoCrashHandler(22493): at com.squareup.leakcanary.LeakCanary.isInAnalyzerProcess(LeakCanary.java:164)
E/GeckoCrashHandler(22493): at com.squareup.leakcanary.LeakCanary.install(LeakCanary.java:50)
E/GeckoCrashHandler(22493): at com.squareup.leakcanary.LeakCanary.install(LeakCanary.java:39)
E/GeckoCrashHandler(22493): at org.mozilla.gecko.GeckoApplication.onCreate(GeckoApplication.java:314)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Bug 1522878 - Disable leak checker in sandboxed processes. r?snorp

Given that we have no control over what this third party code is doing,
we can't reasonably use it in sandboxed processes.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Per snorp, we should just remove this one.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

AFAICT this is long-gone Fennec code. Nothing to do here! \o/