1523020 - Browser Console reports some JS errors when I try to enable logging of CSS errors (and might not actually activate CSS error logging)

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of JS errors

STR:

1. Ctrl+Shift+J to open Browser Console.
   (Optional: click the garbage-can to empty it of anything that's there)

2. Click the funnel icon to the left of "filter output", and click "CSS" to turn on that logging option. (It's off by default.)

ACTUAL RESULTS:
These 5 JavaScript errors immediately appear:

/////

Error while calling actor 'parentProcessTarget's method 'ensureCSSErrorReportingEnabled' Argument 1 of InspectorUtils.getAllStyleSheets is not an object.
protocol.js:1048:5

ensureCSSErrorReportingEnabled@resource://devtools/server/actors/targets/browsing-context.js:1003:9
handler@resource://devtools/shared/protocol.js:1206:21
onPacket@resource://devtools/server/main.js:1279:15
send/<@resource://devtools/shared/transport/local-transport.js:64:11
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
protocol.js:1051:7

stylesheets actor: fetch failed for data:text/css,, using system principal instead.
stylesheets.js:213:5

uncaught exception: Protocol error (unknownError): Argument 1 of InspectorUtils.getAllStyleSheets is not an object.

NS_BASE_STREAM_CLOSED: Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIInputStream.available]
DevToolsUtils.js:607

/////

EXPECTED RESULTS: No such errors.

Comment 2

[:Gijs (he/him)]

Copying some flags from my dupe. Pretty sure this is a regression, might be interesting to work out from what...

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=dc5ea0cbf005b65654b6ed8f44f447011295f0e3&tochange=544320932f97d62f477bedd6296690fb164b846f

Suspect : 544320932f97 Kris Maglione — Bug 1463291: Move docShell getter from Document to Window. r=bz

Comment 4

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/rev/60c4067b1cbb0f94d7dc2d7cdfa27ed579817fee/devtools/server/actors/targets/browsing-context.js#1003 tries to access docShell.document. The document property lives on nsIWebNavigation, at https://searchfox.org/mozilla-central/rev/152993fa346c8fd9296e4cd6622234a664f53341/docshell/base/nsIWebNavigation.idl#305 , and so we need to QI before just assuming that the property is there.

Comment 5

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #3)

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=dc5ea0cbf005b65654b6ed8f44f447011295f0e3&tochange=544320932f97d62f477bedd6296690fb164b846f

Suspect : 544320932f97 Kris Maglione — Bug 1463291: Move docShell getter from Document to Window. r=bz

This was a reasonable guess, but it actually turns out to be https://hg.mozilla.org/integration/mozilla-inbound/rev/60c1c783f5e1 which removed a bunch of nsIWebNavigation QIs.

Comment 6

[:Gijs (he/him)]

(I put up a patch at https://phabricator.services.mozilla.com/D18675 but for some reason phab is not playing ball)

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1523020 - QI docshells to nsIWebNavigation when trying to access their .document property, r?nchevobbe

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68a7366af27b
QI docshells to nsIWebNavigation when trying to access their .document property, r=nchevobbe

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/68a7366af27b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something which should be considered for backport or can it ride the trains?

Comment 11

[:Gijs (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)

Is this something which should be considered for backport or can it ride the trains?

Passing to Nicolas, I'm not sure how much this fixes and if it's worth uplifting.

Nicolas: also, on phab you said you'd file a follow-up - I don't see one on this bug or in your bmo activity, but perhaps I'm missing it?

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

I don't think it's worth uplifting.

Nicolas: also, on phab you said you'd file a follow-up - I don't see one on this bug or in your bmo activity, but perhaps I'm missing it?

Thanks for the reminder, I filed Bug 1529865 for this.