Closed
Bug 1523033
Opened 5 years ago
Closed 5 years ago
Don't export DAV1D_API symbols from libxul
Categories
(Core :: Audio/Video, enhancement, P2)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: away, Assigned: achronop)
References
Details
Attachments
(1 file)
xul.dll is currently dllexporting a bunch of dav1d functions: https://searchfox.org/mozilla-central/rev/465dbfe030dfec7756b9b523029e90d48dd5ecce/third_party/dav1d/include/dav1d/common.h#36
Defining DAV1D_API in this way makes sense when dav1d is built as its own library, but in our use case where everything is in libxul, it's unnecessary.
This also causes dav1d to be wrongly blamed by debuggers (and in turn lost time for developers) for unrelated crashes when debugging symbols are missing. The debugger will guess stacks based on the nearest export symbol, which often winds up being a dav1d function.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → achronop
|
||
Updated•5 years ago
|
Priority: -- → P2
Pushed by achronopoulos@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2e511b5ab2f Define DAV1D_API to empty in order to avoid exporting symbols from libxull. r=dmajor
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•