1523062 - Devirtualize a few nsIPresShell bits.

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1523062 - Devirtualize a few nsIPresShell bits.

No good reason they're virtual, since there's only one nsIPresShell implementation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41d24f9197df
Devirtualize a few nsIPresShell bits. r=TYLin,rhunt

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Well, PresShell.h is now exposed as mozilla/PresShell.h. So, if everybody treats PresShell directly instead of nsIPresShell, we don't need to devirtualize each method since final class's override methods should be resolved at build time...

Comment 4

[Emilio Cobos Álvarez (:emilio)]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #3)

Well, PresShell.h is now exposed as mozilla/PresShell.h. So, if everybody treats PresShell directly instead of nsIPresShell, we don't need to devirtualize each method since final class's override methods should be resolved at build time...

Sure, but that's easier said than done, since most of the users return nsIPresShell (Document::GetShell and pretty much everything else).

We could do a mass-convert the other way around (move users to mozilla::PresShell) and see how it goes, then move everything from nsIPresShell to PresShell.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

We could do a mass-convert the other way around (move users to mozilla::PresShell) and see how it goes, then move everything from nsIPresShell to PresShell.

Yeah, I really want to do it if I had much time...

Comment 6

[Emilio Cobos Álvarez (:emilio)]

$ rg nsIPresShell | wc -l                                                                                                                                                                                       
2122

May not be that terrible actually...

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/41d24f9197df