152312 - I got "command failed" when bootstrapping xpcomsample

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Håkan Waara]

Here's the log from what I did, and what happened. Note that "minimoz" is the
folder above my real source tree.

--

C:\src\mozilla\minimoz>perl bootstrap.pl --module=xpcomsample
root_modules = xpcomsample


Pulling core build files...
cmd = cvs co mozilla/client.mk mozilla/config mozilla/configure mozilla/configur
e.in mozilla/aclocal.m4 mozilla/Makefile.in mozilla/build mozilla/include mozill
a/tools/module-deps
Warning, cmd exited with status 1.


Pulling nspr...
cmd = cvs co -rNSPRPUB_PRE_4_2_CLIENT_BRANCH  mozilla/nsprpub


Pulling modules...
cp mozilla/tools/module-deps/all.dot  mozilla/tools/module-deps/meta.dot

Dependency tree:
  xpcomsample
    xpcom
    xpcomsample
    string


cmd = mozilla/tools/module-deps/module-graph.pl --file mozilla/tools/module-deps
/meta.dot --start-module xpcomsample --list-only --force-order mozilla/tools/mod
ule-deps/force_order.txt
modules = 4

Generating directories list...
cmd = echo string xpcom xpcomsample xpcomsample   | mozilla/config/module2dir.pl
 --list-only

dirs_string_no_mozilla = string xpcom

Checking out directories...
cmd = cvs co mozilla/string mozilla/xpcom

Generating allmakefiles.sh ...
cp mozilla/tools/module-deps/allmakefiles.stub mozilla/allmakefiles.sh

Configuring ...
cmd = ./configure --enable-standalone-modules=xpcomsample --disable-ldap --disab
le-tests --disable-installer
command failed: No such file or directory at bootstrap.pl line 109.

C:\src\mozilla\minimoz>

--

Comment 1

[Chris McAfee]

garrett was getting this error too, I think the wrapper to system() isn't
working for some cases.

Comment 2

[Håkan Waara]

Marking critical, because I can't use the tool (maybe it should be even blocker).

Comment 3

[hacker formerly known as [e-mail]]

Oops.  If we expect this to run on win32 in a non-cygwin shell, we should be
explicitly calling sh to run the configure script.

-  my $configure_cmd = "./configure --enable-standalone-modules=$root_modules
--disable-ldap --disable-tests --disable-installer";
+  my $configure_cmd = "sh ./configure --enable-standalone-modules=$root_modules
--disable-ldap --disable-tests --disable-installer";

Comment 4

[Chris McAfee]

r=mcafee for sh change, this looks fine to me.

Comment 5

[Håkan Waara]

I ran with the change, but it wouldn't build. Not sure why this is. 

Here is the relevant output:

--
Building ...
basedir = /cygdrive/c/src/mozilla/minimoz
make -C mozilla/nsprpub
make: Entering directory `/cygdrive/c/src/mozilla/minimoz/mozilla/nsprpub'
make: *** No targets specified and no makefile found.  Stop.
make: Leaving directory `/cygdrive/c/src/mozilla/minimoz/mozilla/nsprpub'
make -C mozilla/config
make: Entering directory `/cygdrive/c/src/mozilla/minimoz/mozilla/config'
make: *** No targets specified and no makefile found.  Stop.
make: Leaving directory `/cygdrive/c/src/mozilla/minimoz/mozilla/config'
make -C mozilla/xpcom/typelib
make: Entering directory `/cygdrive/c/src/mozilla/minimoz/mozilla/xpcom/typelib'

make: *** No targets specified and no makefile found.  Stop.
make: Leaving directory `/cygdrive/c/src/mozilla/minimoz/mozilla/xpcom/typelib'
make: *** No rule to make target `export-idl'.  Stop.
make: *** No rule to make target `export'.  Stop.
make: *** No rule to make target `libs'.  Stop.
--

Comment 6

[hacker formerly known as [e-mail]]

The configure run failed.  Can you attach the complete output?

Comment 7

[Håkan Waara]

You mean this?

--
Configuring ...
cmd = sh ./configure --enable-standalone-modules=xpcomsample --disable-ldap --di
sable-tests --disable-installer
Warning, cmd exited with status 1.
--

Comment 8

[hacker formerly known as [e-mail]]

Right.  We should be checking the results of $rv since it's obvious that
configure failed there.  Hwaara, do you have a config.log?  Could you also try
removing the '2>&1' from line 109 so  that we can see the actual build output?  

Over to mcafee.

Comment 9

[Håkan Waara]

cls said over IRC that I should print out the $rv of the line where we run the
command. I tried, but got the same output as in comment 7.  mcafee or cls: could
you just run this command:  perl bootstrap.pl --module=xpcomsample and try to
reproduce the bug? I don't come very far with my attempts.

Comment 10

[Chris McAfee]

Attachment: xpcomsample wasn't in the module2dir map, adding it with this patch

Comment 11

[Håkan Waara]

Comment on attachment 88038 [details] [diff] [review]
xpcomsample wasn't in the module2dir map, adding it with this patch

r=hwaara

please checkin the other fix as well.

Comment 12

[Chris McAfee]

Attachment: patch to specify sh on configure line, for bootstrap.pl

here is the patch hwaara is talking about.

Comment 13

[Håkan Waara]

Comment on attachment 88046 [details] [diff] [review]
patch to specify sh on configure line, for bootstrap.pl

r=hwaara

Comment 14

[Alec Flett]

Comment on attachment 88038 [details] [diff] [review]
xpcomsample wasn't in the module2dir map, adding it with this patch

sr=alecf

Comment 15

[Alec Flett]

Comment on attachment 88046 [details] [diff] [review]
patch to specify sh on configure line, for bootstrap.pl

sr=alecf

Comment 16

[Chris McAfee]

Comment on attachment 88046 [details] [diff] [review]
patch to specify sh on configure line, for bootstrap.pl

sh fix checked in

Comment 17

[Chris McAfee]

Comment on attachment 88038 [details] [diff] [review]
xpcomsample wasn't in the module2dir map, adding it with this patch

xpcomsample module2dir.pl entry checked in.

Comment 18

[Chris McAfee]

I can build xpcomsample on linux now, I get dist/{bin,idl,include,lib,sdk} ok.

Comment 19

[Håkan Waara]

I can't find the "sh fix" checkin in bonsai? Did you just forget it, or am I
missing something?

Comment 20

[Håkan Waara]

Sorry, I didn't know bootstrap.pl wasn't in the SeaMonkey CVS module.

Comment 21

[Chris McAfee]

marking fixed, please reopen if it's not working for you.

Comment 22

[Tracy Walker [:tracy]]

verified