1523160 - descriptions missing for SSLVersionMin and SSLVersionMax policies

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[Sören Hentzschel]

Hi,

you forgot to add descriptions for the SSLVersionMin and SSLVersionMax policies in bug 1522182.

Comment 1

[Sören Hentzschel]

Attachment: screenshot (de)

Comment 2

[Mike Kaply [:mkaply]]

Oops.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1523160 - Add descriptions for SSL policies

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b437f336fb38
Add descriptions for SSL policies r=Felipe,flod

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b437f336fb38

Comment 6

[Julien Cristau [:jcristau]]

Is this something we could uplift still?

Comment 7

[Francesco Lodolo [:flod] (OOO Oct 3–10)]

I wouldn't be against it, it's early enough in the cycle to uplift.

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 9039651 [details]
Bug 1523160 - Add descriptions for SSL policies

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1522182

User impact if declined

No description in about:policies

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

Go to about:policies. Verify description is present.

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Very low risk. Adding two strings.

String changes made/needed

Adding two strings. OK by flod

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9039651 [details]
Bug 1523160 - Add descriptions for SSL policies

Just policy descriptions, ok to uplift for beta 6.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/373e61d5d56f

Comment 11

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 67.0a1 (BuildId:20190211092917) and Firefox 66.0b6 (BuildId:20190207161357) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.

The description for SSLVersionMin and SSLVersionMax is successfully displayed.