1523178 - Merge SVGAngle and nsSVGOrientType into SVGOrient

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Robert Longson [:longsonr]]

Only markers have an angle which is actually orient, an angle or auto.

If we model this with a single SVGOrient type we can handle animation better i.e. fix this: https://dxr.mozilla.org/mozilla-central/source/dom/svg/SVGMarkerElement.h#43

and avoid having to override AfterSetAttr and ParseAttribute in SVGMarkerElement

Comment 1

[Robert Longson [:longsonr]]

Attachment: 1523178.txt

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

nsSVGOrientType's methods are merged into SVGAngle which is then renamed to SVGOrient. This fixes the flaw that nsSVGOrientType does not know whether it's animated or not.

Because there's only one orient, the one that marker elements have we can treat it as such.

Also take this opportunity to implement a tear off for the orientType enum.

Comment 3

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c59bd4bd9ca078085b4b3f183ddd1edc3e4d6a9

Comment 4

[Robert Longson [:longsonr]]

Attachment: 1523178.txt

Use a notifier to further simplify the code and ensure correctness.

Ensure we flush animations before returning animated values.

Comment 5

[Robert Longson [:longsonr]]

Attachment: with clang-format

Comment 6

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbc029cee5d6acbd17986d00b19878f69015ebb5

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba2f8df48afd
Merge SVGAngle and nsSVGOrientType into SVGOrient r=jwatt

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ba2f8df48afd