Fix animation delete time

RESOLVED FIXED in Firefox 67

Status

()

defect
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

Bug 1522407 is going to address test_animation_performance_warning.html failure. It addressed test failure, but WebRenderBridgeParent still hit NS_ERROR.

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223987095&repo=try&lineNumber=141628

Error message was "ASSERTION: Tried to delete invalid animation".
https://searchfox.org/mozilla-central/rev/88324fa347928412cb3e4c92418311b7ef5b4271/gfx/layers/wr/WebRenderBridgeParent.cpp#497

Assignee

Updated

4 months ago
Assignee: nobody → sotaro.ikeda.g
Assignee

Updated

4 months ago
Blocks: 1522407
Assignee

Updated

4 months ago
Blocks: 1520705
Assignee

Comment 1

4 months ago

(In reply to Sotaro Ikeda [:sotaro] from comment #0)

Error message was "ASSERTION: Tried to delete invalid animation".

WebRenderBridgeParent::RemoveEpochDataPriorTo() has a problem. Animation was deleted too early in the following STR.

-[1] Request to delete an animation A by WebRenderBridgeParent::RecvDeleteCompositorAnimations()
-[2] Request to re-add the animation A by WebRenderParentCommand::TOpAddCompositorAnimations message
-[3] WebRenderBridgeParent::RemoveEpochDataPriorTo() deletes obsoleted animation

In the STR, [3] removed animation A even when [2] re-added animation A again. It should not be deleted.

Assignee

Updated

4 months ago
Summary: Fix NS_ERROR during test_animation_performance_warning.html test → Fix animation delete time
Assignee

Comment 2

4 months ago

By comment 1, there could be a case that Animation does not run depends on a timing.

Comment 6

4 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1f4d0d6d971
Fix animation delete time r=kats

Comment 7

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.