1523245 - Console stacktrace with collapsed frames have extra new lines when copied

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to https://nchevobbe.github.io/demo/console-test-app.html
2. Open the console
3. Scroll to the bottom, and click on the trace button in the React/Redix section.
4. In the console, you should see 2 console.trace messages, on the last one, click on the React group to expand it
5. Right click and select the Copy message action
6. Paste the result in the console input (or any other input)

Expected results

I get the following:

console.trace() App.js:17
    render App.js:17
    React 12
        finishClassComponent
        updateClassComponent
        beginWork
        performUnitOfWork
        workLoop
        renderRoot
        performWorkOnRoot
        performWork
        performSyncWork
        interactiveUpdates$1
        interactiveUpdates
        dispatchInteractiveEvent

Actual results

I get the following (note the extra new lines):

console.trace() App.js:17
    render App.js:17
    React 12
    
    finishClassComponent
    
    updateClassComponent
    
    beginWork
    
    performUnitOfWork
    
    workLoop
    
    renderRoot
    
    performWorkOnRoot
    
    performWork
    
    performSyncWork
    
    interactiveUpdates$1
    
    interactiveUpdates
    
    dispatchInteractiveEvent

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1523245 - Fix stacktrace with frames group copy; r=bgrins.

This is a follow-up of Bug 1486870.
In this patch we make sure that copying a
stacktrace containing a group, i.e. frames
that were grouped together because they're
part of the same library/framework, are copied
as expected to the clipboard.
There was new lines added between each frames
of the group, because they're in divs.
To fix that, we remove the display: block that
was set for group frames (so they're display: contents,
like the regular frames), and place them in a
grid with only one column (to take the whole horizontal
space).
A br is added in the group description to add a new line
after it.
A test is added to ensure this works as expected.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa32d5cfc223
Fix stacktrace with frames group copy; r=bgrins.

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fa32d5cfc223