1523271 - Revision information still missing

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Ionuț Goldan [:igoldan]]

Turns out that the reland of bug 1519323 didn't entirely fix the missing revision information section.

These links are reproducing the bug:
[1] https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=2c7c37b0ce9ca5f6745140b6551e9faa79e6c099&newProject=mozilla-inbound&newRevision=8686beefb44f25a78bb91bc6d5a9e5582f9ffa9a&framework=10
[2] https://treeherder.mozilla.org/perf.html#/compare?originalProject=autoland&originalRevision=edc9fc80bf25f7bfa6896db4274dfedf4e4bcc76&newProject=autoland&newRevision=c31d2c5695b185f5dab74513f911388ddcb23a46&framework=10

Comment 1

[Sarah Clements [:sclements]]

Ionut, have you made any progress on a patch? The revision information seems to be missing regardless of whether an originalRevision is selected or not. I'll be starting on the compare view conversion in the next few days so it'd be good to have this fixed.

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Sarah Clements [:sclements] from comment #1)

Ionut, have you made any progress on a patch? The revision information seems to be missing regardless of whether an originalRevision is selected or not. I'll be starting on the compare view conversion in the next few days so it'd be good to have this fixed.

No, I haven't looked over this yet. I'm working on it now.

Comment 3

[Ionuț Goldan [:igoldan]]

This is an awkward situation: I'm not able to reproduce the bug locally, while using yarn stage with latest master.

Comment 4

[Ionuț Goldan [:igoldan]]

Sarah, are you having the same issue locally as I am?

Comment 5

[Ionuț Goldan [:igoldan]]

I somehow managed to reproduce the bug on my machine. I've run yarn build + ./manage.py runserver 0:8000 while pointing to the production database. Basically, you need to build FE in production mode.

Resuming my debug now.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4571

Comment 7

[Ionuț Goldan [:igoldan]]

Looks like RevisionInformation component wasn't able to fetch the props from CompareResultsCtrl. They weren't defined in the react2angular's second argument. The docs confused me:

Note: If you defined propTypes on your component, they will be used to compute component's bindings, and you can omit the 2nd argument:

Comment 8

[Sarah Clements [:sclements]]

Yes, I was having the same issue where I wouldn't see the component on production but I would see it while doing local development using the prod server (yarn start).

Comment 9

[Ed Morley [:emorley]]

Landed in:
https://github.com/mozilla/treeherder/commit/5d052ed0d594628ea1ba9eebb5508c3a83ebc692

(the bot that leaves the commit message comment no longer works, so we need to add these manually)