1523285 - CSS outline property isn't applied on inputs with type submit or button

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P2)

Description

[Julien Wajsberg [:julienw]]

STR:

1. Open data:text/html,<style>input { outline: 5px solid blue }</style><input type='submit'/>

=> The outline isn't displayed at all.

This works in Chrome as expected.

This works for <button> elements.

OK in v65 20190124174741
KO in v66 20190127093605 => regression

Comment 1

[Julien Wajsberg [:julienw]]

I know the problem happens on Linux and Windows at least.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Screenshot on nightly

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: screenshot on beta

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e2b466629175004d1b91ba3b9e587bd72b31673e&tochange=587615dad57e5336fbb3dc060cdadaad8078fcca

Regressed by: 587615dad57e Emilio Cobos Álvarez — Bug 1514338 - Remove unneeded special case in nsHTMLButtonControlFrame. r=bzbarsky

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Err...

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky

Sorry, should've seen this :(

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/432ae563202b
Don't clip outlines of a button input and such. r=bzbarsky

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9039554 [details]
Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1514338

User impact if declined

Outlines on some buttons may not show up.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

Yes

If yes, steps to reproduce

See comment 0

List of other uplifts needed

none

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Restores the previous behavior in the most trivial way possible.

String changes made/needed

none

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/432ae563202b

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15228 for changes under testing/web-platform/tests

Comment 11

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 67.0a1 (2019.01.28) and 66.0b4 on Win 10 x64.
I can confirm this issue is fixed, I verified on latest nightly Firefox 67.0a1 (2019.02.04) on Win 10 x64, macOS 10.13 and Ubuntu 18.04 x64.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9039554 [details]
Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky

Fix for regression in 66, verified in nightly.
Let's uplift for beta 5.

[Triage Comment]

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9ab060b915fb

Comment 14

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified on 66.0b5 on Win 10 x64, macOS 10.13 and Ubuntu 16.04 x64.