CSS outline property isn't applied on inputs with type submit or button

VERIFIED FIXED in Firefox 66

Status

()

defect
P2
normal
VERIFIED FIXED
6 months ago
4 months ago

People

(Reporter: julienw, Assigned: emilio)

Tracking

({regression})

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66+ verified, firefox67 verified)

Details

Attachments

(3 attachments)

STR:

  1. Open data:text/html,<style>input { outline: 5px solid blue }</style><input type='submit'/>

=> The outline isn't displayed at all.

This works in Chrome as expected.

This works for <button> elements.

OK in v65 20190124174741
KO in v66 20190127093605 => regression

Summary: CSS outline property isn't applied on inputs wiht type submit or button → CSS outline property isn't applied on inputs with type submit or button

I know the problem happens on Linux and Windows at least.

OS: Unspecified → All
Hardware: Unspecified → All
Posted image screenshot on beta

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e2b466629175004d1b91ba3b9e587bd72b31673e&tochange=587615dad57e5336fbb3dc060cdadaad8078fcca

Regressed by: 587615dad57e Emilio Cobos Álvarez — Bug 1514338 - Remove unneeded special case in nsHTMLButtonControlFrame. r=bzbarsky

Err...

Assignee: nobody → emilio
Priority: -- → P2
Has Regression Range: --- → yes
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/432ae563202b
Don't clip outlines of a button input and such. r=bzbarsky

Comment on attachment 9039554 [details]
Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1514338

User impact if declined

Outlines on some buttons may not show up.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

Yes

If yes, steps to reproduce

See comment 0

List of other uplifts needed

none

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Restores the previous behavior in the most trivial way possible.

String changes made/needed

none

Attachment #9039554 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Flags: qe-verify+
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15228 for changes under testing/web-platform/tests

I have reproduced this issue using Firefox 67.0a1 (2019.01.28) and 66.0b4 on Win 10 x64.
I can confirm this issue is fixed, I verified on latest nightly Firefox 67.0a1 (2019.02.04) on Win 10 x64, macOS 10.13 and Ubuntu 18.04 x64.

Comment on attachment 9039554 [details]
Bug 1523285 - Don't clip outlines of a button input and such. r=bzbarsky

Fix for regression in 66, verified in nightly.
Let's uplift for beta 5.

[Triage Comment]

Attachment #9039554 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [qa-triaged]

I can confirm this issue is fixed, I verified on 66.0b5 on Win 10 x64, macOS 10.13 and Ubuntu 16.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.