1523351 - DualShock 4 support on Windows

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P3)

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1523351 - Part 1: GamepadTouch and GamepadLightIndicator WebAPI implementation.

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1523351 - Part 2: Add tests for GamepadTouch and GamepadLightIndicator.

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1523351 - Part 3: Handling GamepadTouch and GamepadLightIndicator events in Gamepad service.

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1523351 - Part 4: DS4 GamepadTouch and GamepadLightIndicator implementation in Windows.

Comment 5

[Daosheng Mu[:daoshengmu]]

We have implemented the most parts of DS4 support in Windows. I will wait for the try result, and we need to add a test to ensure that two different origins do not see the same touchid value. (Bug 1523350 Comment 2)

Comment 6

[Daosheng Mu[:daoshengmu]]

Attachment: Test page for touchEvents and lightIndicators on DS4.

Comment 7

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1523351 - Part 5: Add LightIndicatorColor dummy functions in other platforms.

Comment 8

[Daosheng Mu[:daoshengmu]]

Try looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=d52064d11c63d2d0079d72f2d45cabaf018a1ff8

Comment 9

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Did the current version of the spec ever get approved after the Intent To Implement thread? I can't find any resolution there.

As for Secure Context APIs in Patch 1, did you add the interface to dom/tests/mochitest/general/test_interfaces.js? That's most likely what you were missing. If you could clean that up as well as the clang-tidy/clang-format requests, that'd be great.

Comment 10

[Daosheng Mu[:daoshengmu]]

(In reply to Kyle Machulis [:qdot] [:kmachulis] from comment #9)

Did the current version of the spec ever get approved after the Intent To Implement thread? I can't find any resolution there.

yes. We got approved at [1], we need to make sure:
(1) touchId cross-origin problem can be solved.
(2) These two APIs need to be restricted to be SecureContext.
(3) the light indicator color would be (0,0,0) by default.

These three things are requested to change in the spec. I have told the proposal's author to modify them.

As for Secure Context APIs in Patch 1, did you add the interface to dom/tests/mochitest/general/test_interfaces.js? That's most likely what you were missing. If you could clean that up as well as the clang-tidy/clang-format requests, that'd be great.

After adding APIs into test_interfaces.js, the test will be failure if the flags are turned off, I need to find a way to turn on them when running API tests.

[1] https://groups.google.com/d/msg/mozilla.dev.platform/75GrJSPHAu0/B_HXSyB9CQAJ

Comment 11

[Daosheng Mu[:daoshengmu]]

Finally, I understood how to make my test to be run at the secure context situation, we need to add scheme = https at dom/tests/mochitest/gamepad/mochitest.ini. Besides, due to dom.gamepad.extensions.multitouch and dom.gamepad.extensions.lightindicator are off by default, so I should make them be disabled at test_interfaces.js.

Comment 12

[Daosheng Mu[:daoshengmu]]

Try looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff9a30e2ddc77852c77606129bc171c24ba8c964

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cac2a77abd09
Part 1: GamepadTouch and GamepadLightIndicator WebAPI implementation. r=baku
https://hg.mozilla.org/integration/autoland/rev/053540f0b00a
Part 2: Add tests for GamepadTouch and GamepadLightIndicator. r=baku
https://hg.mozilla.org/integration/autoland/rev/982cd43dc8d9
Part 3: Handling GamepadTouch and GamepadLightIndicator events in Gamepad service. r=baku
https://hg.mozilla.org/integration/autoland/rev/b8169dcf0631
Part 4: DS4 GamepadTouch and GamepadLightIndicator implementation in Windows. r=aklotz,baku
https://hg.mozilla.org/integration/autoland/rev/607b23dcc62a
Part 5: Add LightIndicatorColor dummy functions in other platforms. r=aklotz

Comment 14

[Daniel Varga [:dvarga]]

Backed out 5 changesets (Bug 1523351) for causing build bustage at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=607b23dcc62a132f9ee349901f6faadb66f71299

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249034960&repo=autoland&lineNumber=6346

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=4c4c08d01af4428b8dc2aa8d2066a81bb7e44ab8

[task 2019-05-29T20:35:17.132Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:127:1: warning: replacement function 'operator new' cannot be declared 'inline' [-Winline-new-delete]
[task 2019-05-29T20:35:17.132Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:134:21: warning: replacement function 'operator new' cannot be declared 'inline' [-Winline-new-delete]
[task 2019-05-29T20:35:17.132Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:139:21: warning: replacement function 'operator new[]' cannot be declared 'inline' [-Winline-new-delete]
[task 2019-05-29T20:35:17.132Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:144:21: warning: replacement function 'operator new[]' cannot be declared 'inline' [-Winline-new-delete]
[task 2019-05-29T20:35:17.132Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:149:21: warning: replacement function 'operator delete' cannot be declared 'inline' [-Winline-new-delete]
[task 2019-05-29T20:35:17.132Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:154:21: warning: replacement function 'operator delete' cannot be declared 'inline' [-Winline-new-delete]
[task 2019-05-29T20:35:17.132Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:159:21: warning: replacement function 'operator delete[]' cannot be declared 'inline' [-Winline-new-delete]
[task 2019-05-29T20:35:17.132Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:164:21: warning: replacement function 'operator delete[]' cannot be declared 'inline' [-Winline-new-delete]
[task 2019-05-29T20:35:17.133Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/nsGkAtoms.h:118:39: warning: offset of on non-standard-layout type 'mozilla::detail::GkAtoms' [-Winvalid-offsetof]
[task 2019-05-29T20:35:17.133Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/js/Proxy.h:222:43: warning: offset of on non-standard-layout type 'js::BaseProxyHandler' [-Winvalid-offsetof]
[task 2019-05-29T20:35:17.133Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BrowsingContext.h:417:29: warning: offset of on non-standard-layout type 'mozilla::dom::BrowsingContext' [-Winvalid-offsetof]
[task 2019-05-29T20:35:17.134Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1224:1: error: too few arguments provided to function-like macro invocation
[task 2019-05-29T20:35:17.134Z] 20:35:17     INFO -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefs.h:99:9: note: macro 'VARCACHE_PREF' defined here
[task 2019-05-29T20:35:17.134Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1231:1: error: too few arguments provided to function-like macro invocation
[task 2019-05-29T20:35:17.134Z] 20:35:17     INFO -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefs.h:99:9: note: macro 'VARCACHE_PREF' defined here
[task 2019-05-29T20:35:17.134Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1220:1: error: unknown type name 'VARCACHE_PREF'
[task 2019-05-29T20:35:17.134Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1238:1: error: too few arguments provided to function-like macro invocation
[task 2019-05-29T20:35:17.134Z] 20:35:17     INFO -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefs.h:99:9: note: macro 'VARCACHE_PREF' defined here
[task 2019-05-29T20:35:17.134Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1227:14: error: expected ';' at end of declaration list
[task 2019-05-29T20:35:17.134Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1245:1: error: too few arguments provided to function-like macro invocation
[task 2019-05-29T20:35:17.134Z] 20:35:17     INFO -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefs.h:99:9: note: macro 'VARCACHE_PREF' defined here
[task 2019-05-29T20:35:17.134Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1256:1: error: use of undeclared identifier 'sVarCache_dom_ipc_tabs_shutdownTimeoutSecs'
[task 2019-05-29T20:35:17.134Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:127:1: warning: replacement function 'operator new' cannot be declared 'inline' [-Winline-new-delete], err: false
[task 2019-05-29T20:35:17.134Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:134:21: warning: replacement function 'operator new' cannot be declared 'inline' [-Winline-new-delete], err: false
[task 2019-05-29T20:35:17.134Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:139:21: warning: replacement function 'operator new[]' cannot be declared 'inline' [-Winline-new-delete], err: false
[task 2019-05-29T20:35:17.134Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:144:21: warning: replacement function 'operator new[]' cannot be declared 'inline' [-Winline-new-delete], err: false
[task 2019-05-29T20:35:17.135Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:149:21: warning: replacement function 'operator delete' cannot be declared 'inline' [-Winline-new-delete], err: false
[task 2019-05-29T20:35:17.136Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:154:21: warning: replacement function 'operator delete' cannot be declared 'inline' [-Winline-new-delete], err: false
[task 2019-05-29T20:35:17.136Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:159:21: warning: replacement function 'operator delete[]' cannot be declared 'inline' [-Winline-new-delete], err: false
[task 2019-05-29T20:35:17.136Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:164:21: warning: replacement function 'operator delete[]' cannot be declared 'inline' [-Winline-new-delete], err: false
[task 2019-05-29T20:35:17.136Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/nsGkAtoms.h:118:39: warning: offset of on non-standard-layout type 'mozilla::detail::GkAtoms' [-Winvalid-offsetof], err: false
[task 2019-05-29T20:35:17.136Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/js/Proxy.h:222:43: warning: offset of on non-standard-layout type 'js::BaseProxyHandler' [-Winvalid-offsetof], err: false
[task 2019-05-29T20:35:17.136Z] 20:35:17  WARNING -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BrowsingContext.h:417:29: warning: offset of on non-standard-layout type 'mozilla::dom::BrowsingContext' [-Winvalid-offsetof], err: false
[task 2019-05-29T20:35:17.136Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1224:1: error: too few arguments provided to function-like macro invocation, err: true
[task 2019-05-29T20:35:17.136Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1231:1: error: too few arguments provided to function-like macro invocation, err: true
[task 2019-05-29T20:35:17.136Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1220:1: error: unknown type name 'VARCACHE_PREF', err: true
[task 2019-05-29T20:35:17.136Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1238:1: error: too few arguments provided to function-like macro invocation, err: true
[task 2019-05-29T20:35:17.136Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1227:14: error: expected ';' at end of declaration list, err: true
[task 2019-05-29T20:35:17.136Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1245:1: error: too few arguments provided to function-like macro invocation, err: true
[task 2019-05-29T20:35:17.136Z] 20:35:17    ERROR -  [style 0.0.1] /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:1256:1: error: use of undeclared identifier 'sVarCache_dom_ipc_tabs_shutdownTimeoutSecs', err: true

Comment 15

[Daosheng Mu[:daoshengmu]]

It seems like I need to rebase and do some changes of StaticPrefList from the current m-c. Thanks for making me know.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bdb7982c3af
Part 1: GamepadTouch and GamepadLightIndicator WebAPI implementation. r=baku
https://hg.mozilla.org/integration/autoland/rev/80b34e6ce876
Part 2: Add tests for GamepadTouch and GamepadLightIndicator. r=baku
https://hg.mozilla.org/integration/autoland/rev/6209717410be
Part 3: Handling GamepadTouch and GamepadLightIndicator events in Gamepad service. r=baku
https://hg.mozilla.org/integration/autoland/rev/13dcba81ff07
Part 4: DS4 GamepadTouch and GamepadLightIndicator implementation in Windows. r=aklotz,baku
https://hg.mozilla.org/integration/autoland/rev/723d0a919d71
Part 5: Add LightIndicatorColor dummy functions in other platforms. r=aklotz

Comment 17

[Daniel Varga [:dvarga]]

Backed out 5 changesets (Bug 1523351) for build bustage at builds/worker/workspace/build/src/dom/gamepad/GamepadRemapping.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=249035820&revision=723d0a919d7123979a56e55dc522653768e69d05

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249050119&repo=autoland&lineNumber=22497

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=92b4171f89df1d75b751c0ab953279e40418bb44

[task 2019-05-29T22:04:04.328Z] 22:04:04     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/gamepad'
[task 2019-05-29T22:04:04.328Z] 22:04:04     INFO -  /builds/worker/workspace/build/src/sccache/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_dom_gamepad0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/gamepad -I/builds/worker/workspace/build/src/obj-firefox/dom/gamepad -I/builds/worker/workspace/build/src/dom/gamepad/ipc -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -MD -MP -MF .deps/Unified_cpp_dom_gamepad0.o.pp   /builds/worker/workspace/build/src/obj-firefox/dom/gamepad/Unified_cpp_dom_gamepad0.cpp
[task 2019-05-29T22:04:04.328Z] 22:04:04     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dom/gamepad/Unified_cpp_dom_gamepad0.cpp:74:0:
[task 2019-05-29T22:04:04.337Z] 22:04:04     INFO -  /builds/worker/workspace/build/src/dom/gamepad/GamepadRemapping.cpp: In member function 'virtual void mozilla::dom::Dualshock4Remapper::GetTouchData(uint32_t, void*)':
[task 2019-05-29T22:04:04.337Z] 22:04:04    ERROR -  /builds/worker/workspace/build/src/dom/gamepad/GamepadRemapping.cpp:436:65: error: suggest parentheses around arithmetic in operand of '|' [-Werror=parentheses]
[task 2019-05-29T22:04:04.337Z] 22:04:04     INFO -           NormalizeTouch(((rawData[41] & 0xf) << 8) | rawData[40] + 1, 0,
[task 2019-05-29T22:04:04.337Z] 22:04:04     INFO -                                                       ~~~~~~~~~~~~^~~
[task 2019-05-29T22:04:04.337Z] 22:04:04     INFO -  cc1plus: all warnings being treated as errors
[task 2019-05-29T22:04:04.337Z] 22:04:04     INFO -  /builds/worker/workspace/build/src/config/rules.mk:810: recipe for target 'Unified_cpp_dom_gamepad0.o' failed
[task 2019-05-29T22:04:04.337Z] 22:04:04    ERROR -  make[4]: *** [Unified_cpp_dom_gamepad0.o] Error 1
[task 2019-05-29T22:04:04.337Z] 22:04:04     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/gamepad'
[task 2019-05-29T22:04:04.337Z] 22:04:04     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'dom/gamepad/target' failed
[task 2019-05-29T22:04:04.337Z] 22:04:04    ERROR -  make[3]: *** [dom/gamepad/target] Error 2
[task 2019-05-29T22:04:04.337Z] 22:04:04     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2019-05-29T22:04:04.353Z] 22:04:04     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/bindings'
[task 2019-05-29T22:04:04.353Z] 22:04:04     INFO -  dom/bindings/UnifiedBindings7.o
[task 2019-05-29T22:04:04.353Z] 22:04:04     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/bindings'
[task 2019-05-29T22:04:04.737Z] 22:04:04     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/geolocation'
[task 2019-05-29T22:04:04.737Z] 22:04:04     INFO -  /builds/worker/workspace/build/src/sccache/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o nsGeolocation.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/geolocation -I/builds/worker/workspace/build/src/obj-firefox/dom/geolocation -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/ipc -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/nsGeolocation.o.pp   /builds/worker/workspace/build/src/dom/geolocation/nsGeolocation.cpp
[task 2019-05-29T22:04:04.737Z] 22:04:04     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/geolocation'
[task 2019-05-29T22:04:04.753Z] 22:04:04     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/bindings'
[task 2019-05-29T22:04:04.753Z] 22:04:04     INFO -  dom/bindings/UnifiedBindings8.o
[task 2019-05-29T22:04:04.753Z] 22:04:04     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/bindings'
[task 2019-05-29T22:04:05.140Z] 22:04:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/events'
[task 2019-05-29T22:04:05.142Z] 22:04:05     INFO -  /builds/worker/workspace/build/src/sccache/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_dom_events3.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/events -I/builds/worker/workspace/build/src/obj-firefox/dom/events -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/dom/storage -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/dom/xml -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/js/xpconnect/wrappers -I/builds/worker/workspace/build/src/layout/forms -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/layout/xul/tree -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_dom_events3.o.pp   /builds/worker/workspace/build/src/obj-firefox/dom/events/Unified_cpp_dom_events3.cpp
[task 2019-05-29T22:04:05.142Z] 22:04:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/events'
[task 2019-05-29T22:04:05.162Z] 22:04:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/bindings'
[task 2019-05-29T22:04:05.162Z] 22:04:05     INFO -  dom/bindings/UnifiedBindings9.o
[task 2019-05-29T22:04:05.162Z] 22:04:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/bindings'
[task 2019-05-29T22:04:06.516Z] 22:04:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/grid'
[task 2019-05-29T22:04:06.520Z] 22:04:06     INFO -  /builds/worker/workspace/build/src/sccache/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_dom_grid0.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/grid -I/builds/worker/workspace/build/src/obj-firefox/dom/grid -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_dom_grid0.o.pp   /builds/worker/workspace/build/src/obj-firefox/dom/grid/Unified_cpp_dom_grid0.cpp
[task 2019-05-29T22:04:06.520Z] 22:04:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/grid'
[task 2019-05-29T22:04:06.536Z] 22:04:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/bindings'
[task 2019-05-29T22:04:06.536Z] 22:04:06     INFO -  dom/bindings/StructuredClone.o

Comment 18

[Daosheng Mu[:daoshengmu]]

Try looks good now.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06a234ef0e29
Part 1: GamepadTouch and GamepadLightIndicator WebAPI implementation. r=baku
https://hg.mozilla.org/integration/autoland/rev/eb4fe237a7fd
Part 2: Add tests for GamepadTouch and GamepadLightIndicator. r=baku
https://hg.mozilla.org/integration/autoland/rev/b560ddb61440
Part 3: Handling GamepadTouch and GamepadLightIndicator events in Gamepad service. r=baku
https://hg.mozilla.org/integration/autoland/rev/7fec5b28c6d8
Part 4: DS4 GamepadTouch and GamepadLightIndicator implementation in Windows. r=aklotz,baku
https://hg.mozilla.org/integration/autoland/rev/1eee1742c141
Part 5: Add LightIndicatorColor dummy functions in other platforms. r=aklotz

Comment 20

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/06a234ef0e29
https://hg.mozilla.org/mozilla-central/rev/eb4fe237a7fd
https://hg.mozilla.org/mozilla-central/rev/b560ddb61440
https://hg.mozilla.org/mozilla-central/rev/7fec5b28c6d8
https://hg.mozilla.org/mozilla-central/rev/1eee1742c141