1523435 - --gecko-profile causes two tabs to load during ts_paint

Status: RESOLVED FIXED

(Testing :: Talos, defect, P3)

Description

[Brendan Dahl [:bdahl]]

When I run:

./mach talos-test -a ts_paint --gecko-profile

I see Firefox load two tabs, each with tspaint_test.html. If I remove "--gecko-profile" I see the expected behavior of a single tab during the test.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1523435 - Do not open two tabs for talos startup tests if the profiler is enabled r?#perftest

It looks like this is a regression from Bug 1121571. This was opening two tabs
instead of one because we are already adding the url to the command line
arguments below:
https://searchfox.org/mozilla-central/rev/40d51bef58b8e901d6ab4b60dd280f372a0e417d/testing/talos/talos/utils.py#165-166

Since we have this addition below, we don't have to do it again inside of this
if branch.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e0414b6e7a9
Do not open two tabs for talos startup tests if the profiler is enabled r=perftest-reviewers,sparky

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5e0414b6e7a9