1523541 - window.innerHeight changes with the dynamic toolbar on Firefox

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Karl Dubost💡 :karlcow]

spin off of https://webcompat.com/issues/20655

0. with Firefox Android
1. Go to http://mattdavella.com/
2. scroll

Actual:
when the URL toolbar disappears, the background image stutters.

The reason is that the parallax JavaScript on the site is dependent on the window.innerHeight value.

see the details in https://webcompat.com/issues/20655

On Chrome the value of window.innerHeight doesn't change if the URL bar appears/disappears.

Opening this bug to track if there are other issues of this type for webcompat.
We may decide that it's not a big enough issue.

Comment 1

[Botond Ballo [:botond]]

I expect this to be fixed by bug 1514429.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

(In reply to Karl Dubost💡 :karlcow from comment #0)

spin off of https://webcompat.com/issues/20655

0. with Firefox Android
1. Go to http://mattdavella.com/
2. scroll

Actual:
when the URL toolbar disappears, the background image stutters.

The reason is that the parallax JavaScript on the site is dependent on the window.innerHeight value.

see the details in https://webcompat.com/issues/20655

On Chrome the value of window.innerHeight doesn't change if the URL bar appears/disappears.

That's probably not because of window.innerHeight. As far as I can tell both of Chrome and Fennec change window.innerHeight when the URL bar is going to be hidden. I've confirmed the value on http://bokand.github.io/demo/urlbarsize.html

I think the issue is caused by the difference of documentElement.clientHeight.

Comment 3

[Firefox Bug Husbandry Bot]

Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.

Comment 4

[Firefox Bug Husbandry Bot]

See bug 1547409. Migrating whiteboard priority tags to program flags.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Karl, do you have an archived version of the site in question? The site has been changed since this bug was filed.

Comment 6

[Karl Dubost💡 :karlcow]

Hiroyuki,

unfortunately, one of these cases, where keeping an archived version would have been good. sorry.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Never mind, then. (It's not your fault at all.) Hope that this will be fixed by bug 1514429, if it's not, will be fixed by bug 1515980.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Copying from bug 1552608 comment 57:

Indeed, I may be wrong here. If Chrome's layout view height matches window.innerHeight (I am also saying scale=1 case),

the layout viewport height is excluding the toolbar height in the case where the toolbar is completely shown
the layout viewport height is excluding the toolbar height as if the toolbar is completely shown in the case of the toolbar transition
the layout viewport height is whole visible area's height in the case where the toolbar is hidden

At least for window.innerHeight this is what Chrome does, so it looks the visual viewport height exeeds the layout viewport height during the toolbar transition, but I haven't actually checked.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

I am going to reuse this bug to change window.innerHeight when the dynamic toolbar is completely hidden or starts to be visible, and fire a window resize event at that time.

window.innerHeight on Chrome

1. is not including the dynamic toolbar height when the dynamic toolbar is visible (regardless of its height)
2. is including the area which was covered by the dynamic toolbar when the dynamic toolbar is completely hidden

Comment 10

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79d0f1921372ff0f6eb677402362327996079899

DynamicToolbarTest.kt failed in the try, but it should pass once after bug 1514429 is fixed.

Comment 11

[Hiroyuki Ikezoe (:hiro)]

The fix in the try is totally wrong. window.innerHeight should be the layout viewport height.

Comment 12

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #11)

The fix in the try is totally wrong. window.innerHeight should be the layout viewport height.

I am going to defer this issue into bug 1598487.

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1523541 - Fire a window resize event at the same time we change position:fixed %-units style values. r?botond

Comment 14

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1523541 - window.innerHeight returns the size for vh units when the dynamic toolbar is completely hidden. r?botond

Depends on D55070

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87bbf1af61ac
Fire a window resize event at the same time we change position:fixed %-units style values. r=botond
https://hg.mozilla.org/integration/autoland/rev/a10194fbd502
window.innerHeight returns the size for vh units when the dynamic toolbar is completely hidden. r=botond

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/87bbf1af61ac
https://hg.mozilla.org/mozilla-central/rev/a10194fbd502