Open Bug 1523541 Opened 10 months ago Updated Last month

window.innerHeight changes with the dynamic toolbar on Firefox

Categories

(Core :: Layout, enhancement, P3)

65 Branch
Unspecified
Android
enhancement

Tracking

()

Webcompat Priority P3
Tracking Status
firefox65 --- affected
firefox66 --- affected
firefox67 --- affected

People

(Reporter: karlcow, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

(Whiteboard: [webcompat] [geckoview:p3])

spin off of https://webcompat.com/issues/20655

  1. with Firefox Android
  2. Go to http://mattdavella.com/
  3. scroll

Actual:
when the URL toolbar disappears, the background image stutters.

The reason is that the parallax JavaScript on the site is dependent on the window.innerHeight value.

see the details in https://webcompat.com/issues/20655

On Chrome the value of window.innerHeight doesn't change if the URL bar appears/disappears.

Opening this bug to track if there are other issues of this type for webcompat.
We may decide that it's not a big enough issue.

Flags: webcompat?

I expect this to be fixed by bug 1514429.

Depends on: 1514429

(In reply to Karl Dubost💡 :karlcow from comment #0)

spin off of https://webcompat.com/issues/20655

  1. with Firefox Android
  2. Go to http://mattdavella.com/
  3. scroll

Actual:
when the URL toolbar disappears, the background image stutters.

The reason is that the parallax JavaScript on the site is dependent on the window.innerHeight value.

see the details in https://webcompat.com/issues/20655

On Chrome the value of window.innerHeight doesn't change if the URL bar appears/disappears.

That's probably not because of window.innerHeight. As far as I can tell both of Chrome and Fennec change window.innerHeight when the URL bar is going to be hidden. I've confirmed the value on http://bokand.github.io/demo/urlbarsize.html

I think the issue is caused by the difference of documentElement.clientHeight.

Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.

Webcompat Priority: --- → ?

See bug 1547409. Migrating whiteboard priority tags to program flags.

Webcompat Priority: ? → P3
Flags: webcompat?

Karl, do you have an archived version of the site in question? The site has been changed since this bug was filed.

Flags: needinfo?(kdubost)

Hiroyuki,

unfortunately, one of these cases, where keeping an archived version would have been good. sorry.

Flags: needinfo?(kdubost)

Never mind, then. (It's not your fault at all.) Hope that this will be fixed by bug 1514429, if it's not, will be fixed by bug 1515980.

See Also: → 1515980
Depends on: 1586147

Copying from bug 1552608 comment 57:

Indeed, I may be wrong here. If Chrome's layout view height matches window.innerHeight (I am also saying scale=1 case),

the layout viewport height is excluding the toolbar height in the case where the toolbar is completely shown
the layout viewport height is excluding the toolbar height as if the toolbar is completely shown in the case of the toolbar transition
the layout viewport height is whole visible area's height in the case where the toolbar is hidden

At least for window.innerHeight this is what Chrome does, so it looks the visual viewport height exeeds the layout viewport height during the toolbar transition, but I haven't actually checked.

Whiteboard: [webcompat] → [webcompat] [geckoview:p3]
You need to log in before you can comment on or make changes to this bug.